Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 2401573002: Allow active sheets to have nullptr for RuleSet. (Closed)

Created:
4 years, 2 months ago by rune
Modified:
4 years, 2 months ago
Reviewers:
meade_UTC10
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow active sheets to have nullptr for RuleSet. CSSStyleSheets which have a non-matching media attribute may have a nullptr for RuleSet since it's not needed. Handle that in active style- sheet diffing. That means adding a sheet with non-matching media should not cause any style recalculations. R=meade@chromium.org BUG=567021 Committed: https://crrev.com/bb06955a67e20f613553b44a7b89c2ae0a2ba5f1 Cr-Commit-Position: refs/heads/master@{#423804}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -12 lines) Patch
M third_party/WebKit/Source/core/css/ActiveStyleSheets.cpp View 4 chunks +22 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/css/ActiveStyleSheetsTest.cpp View 1 chunk +78 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
rune
ptal
4 years, 2 months ago (2016-10-06 13:12:54 UTC) #3
meade_UTC10
lgtm
4 years, 2 months ago (2016-10-07 00:58:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2401573002/1
4 years, 2 months ago (2016-10-07 05:59:27 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 06:05:07 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 06:06:47 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb06955a67e20f613553b44a7b89c2ae0a2ba5f1
Cr-Commit-Position: refs/heads/master@{#423804}

Powered by Google App Engine
This is Rietveld 408576698