Add CSS support for text-decoration-skip

Add CSS support for text-decoration-skip

Add text-decoration-skip parsing and value computed style value support
for values objects (the default) and ink.  Still behind the CSS3
text-decoration flag for now.

BUG=649700, 581456
Committed: https://crrev.com/750ed7a13da275f7afa3c8ec38fb01bc3a7f30f0
Cr-Commit-Position: refs/heads/master@{#424393}

[drott, 2016-10-08 11:24:49]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-08 11:24:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-08 12:29:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-08 12:29:10]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[drott, 2016-10-10 13:07:35]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-10 13:07:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[drott, 2016-10-10 13:08:01]

Description was changed from

==========
Add CSS support for text-decoration-skip

Add text-decoration-skip parsing and value computed style value support
for values objects (the default) and ink.  Still behind the CSS3
text-decoration flag for now.

TODO: tests

BUG=649700, 581456
==========

to

==========
Add CSS support for text-decoration-skip

Add text-decoration-skip parsing and value computed style value support
for values objects (the default) and ink.  Still behind the CSS3
text-decoration flag for now.

BUG=649700, 581456
==========

[drott, 2016-10-10 13:09:05]

drott@chromium.org changed reviewers:
+ eae@chromium.org, timloh@chromium.org

[eae, 2016-10-10 15:45:08]

LGTM

[commit-bot: I haz the power, 2016-10-10 17:27:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 17:27:10]

Dry run: This issue passed the CQ dry run.

[Timothy Loh, 2016-10-11 00:00:33]

lgtm

https://codereview.chromium.org/2394273006/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
(right):

https://codereview.chromium.org/2394273006/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp:1133: return
CSSIdentifierValue::create(CSSValueObjects);
Maybe better to DCHECK(list->length()) for now instead?

https://codereview.chromium.org/2394273006/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2394273006/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:89877: +  <int value="546"
label="text-decoration-style"/>
style->skip? Not sure if you were manually editing this but
update_use_counter_css.py should do it for you next time.

[drott, 2016-10-11 07:15:28]

Thanks for the review.

https://codereview.chromium.org/2394273006/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
(right):

https://codereview.chromium.org/2394273006/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp:1133: return
CSSIdentifierValue::create(CSSValueObjects);
On 2016/10/11 at 00:00:33, Timothy Loh wrote:
> Maybe better to DCHECK(list->length()) for now instead?

Done.

https://codereview.chromium.org/2394273006/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2394273006/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:89877: +  <int value="546"
label="text-decoration-style"/>
On 2016/10/11 at 00:00:33, Timothy Loh wrote:
> style->skip? Not sure if you were manually editing this but
update_use_counter_css.py should do it for you next time.

Thanks, good catch, I am not sure how that got there since I did use the script.

[drott, 2016-10-11 07:19:23]

drott@chromium.org changed reviewers:
+ jochen@chromium.org, mkwst@chromium.org

[drott, 2016-10-11 07:19:50]

mkwst@, jochen@ - could you please take a look at histograms.xml/UseCounter.cpp?
Thanks.

[drott, 2016-10-11 07:20:10]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 07:20:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mike West, 2016-10-11 08:35:05]

UseCounter/Histograms LGTM.

[drott, 2016-10-11 08:45:34]

The CQ bit was unchecked by drott@chromium.org

[drott, 2016-10-11 08:45:36]

The CQ bit was checked by drott@chromium.org

[drott, 2016-10-11 08:45:36]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org,
eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2394273006/#ps40001
(title: "Histograms typo fixed, DCHECK")

[commit-bot: I haz the power, 2016-10-11 08:45:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 08:53:12]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-11 08:55:21]

Description was changed from

==========
Add CSS support for text-decoration-skip

Add text-decoration-skip parsing and value computed style value support
for values objects (the default) and ink.  Still behind the CSS3
text-decoration flag for now.

BUG=649700, 581456
==========

to

==========
Add CSS support for text-decoration-skip

Add text-decoration-skip parsing and value computed style value support
for values objects (the default) and ink.  Still behind the CSS3
text-decoration flag for now.

BUG=649700, 581456

Committed: https://crrev.com/750ed7a13da275f7afa3c8ec38fb01bc3a7f30f0
Cr-Commit-Position: refs/heads/master@{#424393}
==========

[commit-bot: I haz the power, 2016-10-11 08:55:23]

Patchset 3 (id:??) landed as
https://crrev.com/750ed7a13da275f7afa3c8ec38fb01bc3a7f30f0
Cr-Commit-Position: refs/heads/master@{#424393}