third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp - Issue 2394273006: Add CSS support for text-decoration-skip

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp

Issue 2394273006: Add CSS support for text-decoration-skip (Closed)

Patch Set: Histograms typo fixed, DCHECK Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp

diff --git a/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp b/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp

index 5e9f005a0c0267be4f13b4988557751940e6ae45..db6324b8350c14e89883777228d676c8b30a956c 100644

--- a/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp

+++ b/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp

@@ -1359,6 +1359,7 @@ static inline bool isValidCueStyleProperty(CSSPropertyID id) {

case CSSPropertyTextDecorationLine:

case CSSPropertyTextDecorationStyle:

case CSSPropertyTextDecorationColor:

+ case CSSPropertyTextDecorationSkip:

return RuntimeEnabledFeatures::css3TextDecorationsEnabled();

default:

break;

@@ -1468,6 +1469,7 @@ static inline bool isValidFirstLetterStyleProperty(CSSPropertyID id) {

case CSSPropertyTextDecorationColor:

case CSSPropertyTextDecorationLine:

case CSSPropertyTextDecorationStyle:

+ case CSSPropertyTextDecorationSkip:

ASSERT(RuntimeEnabledFeatures::css3TextDecorationsEnabled());

return true;