Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1033)

Side by Side Diff: third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp

Issue 2394273006: Add CSS support for text-decoration-skip (Closed)
Patch Set: Histograms typo fixed, DCHECK Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com) 4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. 5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc.
6 * All rights reserved. 6 * All rights reserved.
7 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 7 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
8 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org> 8 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
9 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. 9 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.
10 * (http://www.torchmobile.com/) 10 * (http://www.torchmobile.com/)
(...skipping 1341 matching lines...) Expand 10 before | Expand all | Expand 10 after
1352 case CSSPropertyWhiteSpace: 1352 case CSSPropertyWhiteSpace:
1353 // FIXME: 'text-decoration' shorthand to be handled when available. 1353 // FIXME: 'text-decoration' shorthand to be handled when available.
1354 // See https://chromiumcodereview.appspot.com/19516002 for details. 1354 // See https://chromiumcodereview.appspot.com/19516002 for details.
1355 case CSSPropertyTextDecoration: 1355 case CSSPropertyTextDecoration:
1356 case CSSPropertyTextShadow: 1356 case CSSPropertyTextShadow:
1357 case CSSPropertyBorderStyle: 1357 case CSSPropertyBorderStyle:
1358 return true; 1358 return true;
1359 case CSSPropertyTextDecorationLine: 1359 case CSSPropertyTextDecorationLine:
1360 case CSSPropertyTextDecorationStyle: 1360 case CSSPropertyTextDecorationStyle:
1361 case CSSPropertyTextDecorationColor: 1361 case CSSPropertyTextDecorationColor:
1362 case CSSPropertyTextDecorationSkip:
1362 return RuntimeEnabledFeatures::css3TextDecorationsEnabled(); 1363 return RuntimeEnabledFeatures::css3TextDecorationsEnabled();
1363 default: 1364 default:
1364 break; 1365 break;
1365 } 1366 }
1366 return false; 1367 return false;
1367 } 1368 }
1368 1369
1369 static inline bool isValidFirstLetterStyleProperty(CSSPropertyID id) { 1370 static inline bool isValidFirstLetterStyleProperty(CSSPropertyID id) {
1370 switch (id) { 1371 switch (id) {
1371 // Valid ::first-letter properties listed in spec: 1372 // Valid ::first-letter properties listed in spec:
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
1461 case CSSPropertyWebkitMarginStart: 1462 case CSSPropertyWebkitMarginStart:
1462 case CSSPropertyWebkitMarginTopCollapse: 1463 case CSSPropertyWebkitMarginTopCollapse:
1463 case CSSPropertyWordSpacing: 1464 case CSSPropertyWordSpacing:
1464 return true; 1465 return true;
1465 case CSSPropertyTextDecoration: 1466 case CSSPropertyTextDecoration:
1466 ASSERT(!RuntimeEnabledFeatures::css3TextDecorationsEnabled()); 1467 ASSERT(!RuntimeEnabledFeatures::css3TextDecorationsEnabled());
1467 return true; 1468 return true;
1468 case CSSPropertyTextDecorationColor: 1469 case CSSPropertyTextDecorationColor:
1469 case CSSPropertyTextDecorationLine: 1470 case CSSPropertyTextDecorationLine:
1470 case CSSPropertyTextDecorationStyle: 1471 case CSSPropertyTextDecorationStyle:
1472 case CSSPropertyTextDecorationSkip:
1471 ASSERT(RuntimeEnabledFeatures::css3TextDecorationsEnabled()); 1473 ASSERT(RuntimeEnabledFeatures::css3TextDecorationsEnabled());
1472 return true; 1474 return true;
1473 1475
1474 // text-shadow added in text decoration spec: 1476 // text-shadow added in text decoration spec:
1475 // http://www.w3.org/TR/css-text-decor-3/#text-shadow-property 1477 // http://www.w3.org/TR/css-text-decor-3/#text-shadow-property
1476 case CSSPropertyTextShadow: 1478 case CSSPropertyTextShadow:
1477 // box-shadox added in CSS3 backgrounds spec: 1479 // box-shadox added in CSS3 backgrounds spec:
1478 // http://www.w3.org/TR/css3-background/#placement 1480 // http://www.w3.org/TR/css3-background/#placement
1479 case CSSPropertyBoxShadow: 1481 case CSSPropertyBoxShadow:
1480 // Properties that we currently support outside of spec. 1482 // Properties that we currently support outside of spec.
(...skipping 463 matching lines...) Expand 10 before | Expand all | Expand 10 after
1944 visitor->trace(m_siblingRuleSet); 1946 visitor->trace(m_siblingRuleSet);
1945 visitor->trace(m_uncommonAttributeRuleSet); 1947 visitor->trace(m_uncommonAttributeRuleSet);
1946 visitor->trace(m_watchedSelectorsRules); 1948 visitor->trace(m_watchedSelectorsRules);
1947 visitor->trace(m_treeBoundaryCrossingScopes); 1949 visitor->trace(m_treeBoundaryCrossingScopes);
1948 visitor->trace(m_styleSharingLists); 1950 visitor->trace(m_styleSharingLists);
1949 visitor->trace(m_pendingStyleSheets); 1951 visitor->trace(m_pendingStyleSheets);
1950 visitor->trace(m_document); 1952 visitor->trace(m_document);
1951 } 1953 }
1952 1954
1953 } // namespace blink 1955 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp ('k') | third_party/WebKit/Source/core/frame/UseCounter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698