[Android] Permanently disable "All bookmarks" and remove its experiment

[Android] Permanently disable "All bookmarks" and remove its experiment

This CL reverts the following CLs:
1. "Change testing trial to be Disabled for All Bookmarks" (d7e42ebb7ffab7b19303abc69bcec577938ad8ea)
2. Make "All Bookmarks" to be controlled by feature" (b8a3ebb9e0ed8f14db3182991fd1cec16ba43339)
3. "Add an about flag to toggle the visibility of "All bookmarks"" (d37c3af126cb22a7831032b22a7c24bb2628c4bc)
4. "Revert "Remove all bookmark section from bookmark manager"" (837a30e53b89b813b463953238ce24272c48c58a)

BUG=605614
R=dfalcantara@chromium.org, isherman@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/c8cd68d034aa94cfe6fbbedf402099d147689851

[Ian Wen, 2016-10-06 18:55:09]

ianwen@chromium.org changed reviewers:
+ dfalcantara@chromium.org, isherman@chromium.org

[Ian Wen, 2016-10-06 18:55:09]

Hi reviewers,

This CL reverts 4 CLs you have reviewed before. PTAL :)

isherman@chromium.org: Please review changes in metrics

dfalcantara@chromium.org: Please review changes in chrome

[Ilya Sherman, 2016-10-06 19:05:43]

https://codereview.chromium.org/2394273002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/2394273002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:88090: -  <int value="-1212855900"
label="enable-all-bookmarks-view"/>
Please leave this entry in place.  (And, after you do, I think you don't need my
review.)

[Ilya Sherman, 2016-10-06 19:06:21]

Oh, j/k, there's also the field trial config change.  That LGTM, but please
revert the change to histograms.xml.

[Ian Wen, 2016-10-06 19:58:17]

The CQ bit was checked by ianwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 19:58:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 20:09:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 20:09:51]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Ian Wen, 2016-10-06 20:24:44]

The CQ bit was checked by ianwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 20:25:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gone, 2016-10-06 20:37:31]

lgtm

https://chromiumcodereview.appspot.com/2394273002/diff/40001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUIState.java
(right):

https://chromiumcodereview.appspot.com/2394273002/diff/40001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUIState.java:20:
private static final int STATE_INVALID = 0;
should this be above the other two?

[gone, 2016-10-06 20:51:50]

lgtm

[commit-bot: I haz the power, 2016-10-06 21:27:18]

Description was changed from

==========
[Android] Permanently disable "All bookmarks" and remove its experiment

This CL reverts the following CLs:
1. "Change testing trial to be Disabled for All Bookmarks"
(d7e42ebb7ffab7b19303abc69bcec577938ad8ea)
2. Make "All Bookmarks" to be controlled by feature"
(b8a3ebb9e0ed8f14db3182991fd1cec16ba43339)
3. "Add an about flag to toggle the visibility of "All bookmarks""
(d37c3af126cb22a7831032b22a7c24bb2628c4bc)
4. "Revert "Remove all bookmark section from bookmark manager""
(837a30e53b89b813b463953238ce24272c48c58a)

BUG=605614
==========

to

==========
[Android] Permanently disable "All bookmarks" and remove its experiment

This CL reverts the following CLs:
1. "Change testing trial to be Disabled for All Bookmarks"
(d7e42ebb7ffab7b19303abc69bcec577938ad8ea)
2. Make "All Bookmarks" to be controlled by feature"
(b8a3ebb9e0ed8f14db3182991fd1cec16ba43339)
3. "Add an about flag to toggle the visibility of "All bookmarks""
(d37c3af126cb22a7831032b22a7c24bb2628c4bc)
4. "Revert "Remove all bookmark section from bookmark manager""
(837a30e53b89b813b463953238ce24272c48c58a)

BUG=605614
R=dfalcantara@chromium.org, isherman@chromium.org

Committed: https://crrev.com/c8cd68d034aa94cfe6fbbedf402099d147689851
Cr-Commit-Position: refs/heads/master@{#423686}
==========

[commit-bot: I haz the power, 2016-10-06 21:27:19]

Patchset 3 (id:??) landed as
https://crrev.com/c8cd68d034aa94cfe6fbbedf402099d147689851
Cr-Commit-Position: refs/heads/master@{#423686}

[Ian Wen, 2016-10-06 21:31:18]

Description was changed from

==========
[Android] Permanently disable "All bookmarks" and remove its experiment

This CL reverts the following CLs:
1. "Change testing trial to be Disabled for All Bookmarks"
(d7e42ebb7ffab7b19303abc69bcec577938ad8ea)
2. Make "All Bookmarks" to be controlled by feature"
(b8a3ebb9e0ed8f14db3182991fd1cec16ba43339)
3. "Add an about flag to toggle the visibility of "All bookmarks""
(d37c3af126cb22a7831032b22a7c24bb2628c4bc)
4. "Revert "Remove all bookmark section from bookmark manager""
(837a30e53b89b813b463953238ce24272c48c58a)

BUG=605614
R=dfalcantara@chromium.org, isherman@chromium.org

Committed: https://crrev.com/c8cd68d034aa94cfe6fbbedf402099d147689851
Cr-Commit-Position: refs/heads/master@{#423686}
==========

to

==========
[Android] Permanently disable "All bookmarks" and remove its experiment

This CL reverts the following CLs:
1. "Change testing trial to be Disabled for All Bookmarks"
(d7e42ebb7ffab7b19303abc69bcec577938ad8ea)
2. Make "All Bookmarks" to be controlled by feature"
(b8a3ebb9e0ed8f14db3182991fd1cec16ba43339)
3. "Add an about flag to toggle the visibility of "All bookmarks""
(d37c3af126cb22a7831032b22a7c24bb2628c4bc)
4. "Revert "Remove all bookmark section from bookmark manager""
(837a30e53b89b813b463953238ce24272c48c58a)

BUG=605614
R=dfalcantara@chromium.org, isherman@chromium.org

Committed:
https://chromium.googlesource.com/chromium/src/+/c8cd68d034aa94cfe6fbbedf4020...
==========

[Ian Wen, 2016-10-06 21:31:19]

Committed patchset #3 (id:40001) manually as
c8cd68d034aa94cfe6fbbedf402099d147689851 (presubmit successful).