Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3364)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkActionBar.java

Issue 2394273002: [Android] Permanently disable "All bookmarks" and remove its experiment (Closed)
Patch Set: isherman's comment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkActionBar.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkActionBar.java b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkActionBar.java
index a18d91b414a3c599d11041af2783d98ecf124149..8948d22e82cd400dbe6f0858891a19506bbff8f4 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkActionBar.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkActionBar.java
@@ -140,26 +140,17 @@ public class BookmarkActionBar extends SelectionToolbar<BookmarkId> implements B
}
@Override
- public void onAllBookmarksStateSet() {
- setTitle(R.string.bookmark_title_bar_all_items);
- setNavigationButton(NAVIGATION_BUTTON_MENU);
- getMenu().findItem(R.id.search_menu_id).setVisible(true);
- getMenu().findItem(R.id.edit_menu_id).setVisible(false);
- }
-
- @Override
public void onFolderStateSet(BookmarkId folder) {
mCurrentFolder = mDelegate.getModel().getBookmarkById(folder);
- getMenu().findItem(R.id.search_menu_id)
- .setVisible(!BookmarkUtils.isAllBookmarksViewEnabled());
+ getMenu().findItem(R.id.search_menu_id).setVisible(true);
getMenu().findItem(R.id.edit_menu_id).setVisible(mCurrentFolder.isEditable());
// If the parent folder is a top level node, we don't go up anymore.
if (mDelegate.getModel().getTopLevelFolderParentIDs().contains(
mCurrentFolder.getParentId())) {
if (TextUtils.isEmpty(mCurrentFolder.getTitle())) {
- setTitle(R.string.bookmark_title_bar_all_items);
+ setTitle(R.string.bookmarks);
} else {
setTitle(mCurrentFolder.getTitle());
}

Powered by Google App Engine
This is Rietveld 408576698