[Findit] Hacky solution to map a CQ trybot step to a Waterfall buildbot step.

[Findit] Hacky solution to map a CQ trybot step to a Waterfall buildbot step.

BUG=648743, 648751
Committed: https://chromium.googlesource.com/infra/infra/+/08f1a6fd0551b5bf6cb94110bfaf448477b0514e

[stgao, 2016-10-05 20:04:34]

stgao@chromium.org changed reviewers:
+ chanli@chromium.org, lijeffrey@chromium.org

[stgao, 2016-10-05 20:04:35]

ptal

[chanli, 2016-10-07 01:04:52]

https://codereview.chromium.org/2394013002/diff/20001/appengine/findit/waterf...
File appengine/findit/waterfall/flake/step_mapper.py (right):

https://codereview.chromium.org/2394013002/diff/20001/appengine/findit/waterf...
appengine/findit/waterfall/flake/step_mapper.py:95: return  # No recent builds
for the buildbot.
return no_matching_result? Or maybe just continue with next configuration?

https://codereview.chromium.org/2394013002/diff/20001/appengine/findit/waterf...
appengine/findit/waterfall/flake/step_mapper.py:97: # 4. Check whether there is
matching step.
I think we should. If a test is os specifically flaky, we may run on the wrong
configuration. 

And since we can get os from demensions, it should be easy to check.

https://codereview.chromium.org/2394013002/diff/20001/appengine/findit/waterf...
appengine/findit/waterfall/flake/step_mapper.py:108: def
FindMatchingWaterfallStep(build_step):  # pragma: no cover.
Is there any return value for this function? Or do you need to store the change
on build_step?

https://codereview.chromium.org/2394013002/diff/20001/appengine/findit/waterf...
File appengine/findit/waterfall/swarming_util.py (right):

https://codereview.chromium.org/2394013002/diff/20001/appengine/findit/waterf...
appengine/findit/waterfall/swarming_util.py:95: additional_tag_filters(dict):
More tag filters to be added.
Nit: add other args as well?

[chanli, 2016-10-07 01:08:37]

https://codereview.chromium.org/2394013002/diff/20001/appengine/findit/waterf...
File appengine/findit/waterfall/flake/step_mapper.py (right):

https://codereview.chromium.org/2394013002/diff/20001/appengine/findit/waterf...
appengine/findit/waterfall/flake/step_mapper.py:94: logging.error('Failed to
retrieve recent builds on %s', wf_master_name)
There is logging at GetRecentCompletedBuilds side already

[stgao, 2016-10-07 01:19:33]

https://codereview.chromium.org/2394013002/diff/20001/appengine/findit/waterf...
File appengine/findit/waterfall/flake/step_mapper.py (right):

https://codereview.chromium.org/2394013002/diff/20001/appengine/findit/waterf...
appengine/findit/waterfall/flake/step_mapper.py:94: logging.error('Failed to
retrieve recent builds on %s', wf_master_name)
On 2016/10/07 01:08:37, chanli wrote:
> There is logging at GetRecentCompletedBuilds side already

Good catch. Removed here.

https://codereview.chromium.org/2394013002/diff/20001/appengine/findit/waterf...
appengine/findit/waterfall/flake/step_mapper.py:95: return  # No recent builds
for the buildbot.
On 2016/10/07 01:04:52, chanli wrote:
> return no_matching_result? Or maybe just continue with next configuration?

Good catch! Let's continue with next configuration.

https://codereview.chromium.org/2394013002/diff/20001/appengine/findit/waterf...
appengine/findit/waterfall/flake/step_mapper.py:97: # 4. Check whether there is
matching step.
On 2016/10/07 01:04:52, chanli wrote:
> I think we should. If a test is os specifically flaky, we may run on the wrong
> configuration. 
> 
> And since we can get os from demensions, it should be easy to check.

Done.

https://codereview.chromium.org/2394013002/diff/20001/appengine/findit/waterf...
appengine/findit/waterfall/flake/step_mapper.py:108: def
FindMatchingWaterfallStep(build_step):  # pragma: no cover.
On 2016/10/07 01:04:52, chanli wrote:
> Is there any return value for this function? Or do you need to store the
change
> on build_step?

No return value. Information will be updated directly into the given build_step
as explained in the docstring.

https://codereview.chromium.org/2394013002/diff/20001/appengine/findit/waterf...
File appengine/findit/waterfall/swarming_util.py (right):

https://codereview.chromium.org/2394013002/diff/20001/appengine/findit/waterf...
appengine/findit/waterfall/swarming_util.py:95: additional_tag_filters(dict):
More tag filters to be added.
On 2016/10/07 01:04:52, chanli wrote:
> Nit: add other args as well?

Done.

[stgao, 2016-10-07 02:10:27]

Description was changed from

==========
[Findit] Hacky solution to map a CQ trybot step to a Waterfall buildbot step.

BUG=648743
==========

to

==========
[Findit] Hacky solution to map a CQ trybot step to a Waterfall buildbot step.

BUG=648743, 648751
==========

[chanli, 2016-10-07 17:26:33]

On 2016/10/07 01:19:33, stgao (slow) wrote:
>
https://codereview.chromium.org/2394013002/diff/20001/appengine/findit/waterf...
> File appengine/findit/waterfall/flake/step_mapper.py (right):
> 
>
https://codereview.chromium.org/2394013002/diff/20001/appengine/findit/waterf...
> appengine/findit/waterfall/flake/step_mapper.py:94: logging.error('Failed to
> retrieve recent builds on %s', wf_master_name)
> On 2016/10/07 01:08:37, chanli wrote:
> > There is logging at GetRecentCompletedBuilds side already
> 
> Good catch. Removed here.
> 
>
https://codereview.chromium.org/2394013002/diff/20001/appengine/findit/waterf...
> appengine/findit/waterfall/flake/step_mapper.py:95: return  # No recent builds
> for the buildbot.
> On 2016/10/07 01:04:52, chanli wrote:
> > return no_matching_result? Or maybe just continue with next configuration?
> 
> Good catch! Let's continue with next configuration.
> 
>
https://codereview.chromium.org/2394013002/diff/20001/appengine/findit/waterf...
> appengine/findit/waterfall/flake/step_mapper.py:97: # 4. Check whether there
is
> matching step.
> On 2016/10/07 01:04:52, chanli wrote:
> > I think we should. If a test is os specifically flaky, we may run on the
wrong
> > configuration. 
> > 
> > And since we can get os from demensions, it should be easy to check.
> 
> Done.
> 
>
https://codereview.chromium.org/2394013002/diff/20001/appengine/findit/waterf...
> appengine/findit/waterfall/flake/step_mapper.py:108: def
> FindMatchingWaterfallStep(build_step):  # pragma: no cover.
> On 2016/10/07 01:04:52, chanli wrote:
> > Is there any return value for this function? Or do you need to store the
> change
> > on build_step?
> 
> No return value. Information will be updated directly into the given
build_step
> as explained in the docstring.
> 
>
https://codereview.chromium.org/2394013002/diff/20001/appengine/findit/waterf...
> File appengine/findit/waterfall/swarming_util.py (right):
> 
>
https://codereview.chromium.org/2394013002/diff/20001/appengine/findit/waterf...
> appengine/findit/waterfall/swarming_util.py:95: additional_tag_filters(dict):
> More tag filters to be added.
> On 2016/10/07 01:04:52, chanli wrote:
> > Nit: add other args as well?
> 
> Done.

lgtm

[stgao, 2016-10-07 17:53:06]

The CQ bit was checked by stgao@chromium.org

[commit-bot: I haz the power, 2016-10-07 17:53:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 18:07:20]

Description was changed from

==========
[Findit] Hacky solution to map a CQ trybot step to a Waterfall buildbot step.

BUG=648743, 648751
==========

to

==========
[Findit] Hacky solution to map a CQ trybot step to a Waterfall buildbot step.

BUG=648743, 648751

Committed:
https://chromium.googlesource.com/infra/infra/+/08f1a6fd0551b5bf6cb94110bfaf4...
==========

[commit-bot: I haz the power, 2016-10-07 18:07:21]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/infra/infra/+/08f1a6fd0551b5bf6cb94110bfaf4...