appengine/findit/waterfall/trigger_base_swarming_task_pipeline.py - Issue 2394013002: [Findit] Hacky solution to map a CQ trybot step to a Waterfall buildbot step.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/waterfall/trigger_base_swarming_task_pipeline.py

Issue 2394013002: [Findit] Hacky solution to map a CQ trybot step to a Waterfall buildbot step. (Closed)

Patch Set: Fix nit. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/findit/waterfall/trigger_base_swarming_task_pipeline.py

diff --git a/appengine/findit/waterfall/trigger_base_swarming_task_pipeline.py b/appengine/findit/waterfall/trigger_base_swarming_task_pipeline.py

index bef1bdab0bd12584575d9089ce720d324ead3909..5a70146ecdf6fe9a38cd8d2cedcc49b65c920237 100644

--- a/appengine/findit/waterfall/trigger_base_swarming_task_pipeline.py

+++ b/appengine/findit/waterfall/trigger_base_swarming_task_pipeline.py

@@ -151,7 +151,8 @@ class TriggerBaseSwarmingTaskPipeline(BasePipeline): # pragma: no cover.

# 0. Retrieve existing Swarming task ids for the given step.

swarming_task_items = swarming_util.ListSwarmingTasksDataByTags(

- master_name, builder_name, build_number, http_client, step_name)

+ master_name, builder_name, build_number, http_client,

+ {'stepname': step_name})

assert len(swarming_task_items) > 0, 'No Swarming task was run.'

ref_task_id = swarming_task_items[0]['task_id']