Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5649)

Unified Diff: appengine/findit/model/flake/flake_analysis_request.py

Issue 2394013002: [Findit] Hacky solution to map a CQ trybot step to a Waterfall buildbot step. (Closed)
Patch Set: Fix nit. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | appengine/findit/model/flake/test/flake_analysis_request_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/model/flake/flake_analysis_request.py
diff --git a/appengine/findit/model/flake/flake_analysis_request.py b/appengine/findit/model/flake/flake_analysis_request.py
index a5351f73e256a514602c434074b329ea0fac4373..1c9c4f9244478c7c6df195d04096ab20a7a7230d 100644
--- a/appengine/findit/model/flake/flake_analysis_request.py
+++ b/appengine/findit/model/flake/flake_analysis_request.py
@@ -55,6 +55,11 @@ class BuildStep(ndb.Model):
step_name=step_name,
reported_time=reported_time)
+ @property
+ def has_matching_waterfall_step(self):
+ return None not in (self.wf_master_name, self.wf_builder_name,
+ self.wf_build_number, self.wf_step_name)
+
class FlakeAnalysisRequest(VersionedModel):
"""Represents a request to analyze a flake.
« no previous file with comments | « no previous file | appengine/findit/model/flake/test/flake_analysis_request_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698