Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2393993005: Revert "[Custom Tabs] Implement "Read It Later" Behind a Flag" (Closed)

Created:
4 years, 2 months ago by Ian Wen
Modified:
4 years, 2 months ago
Reviewers:
Yusuf, Ilya Sherman, gone
CC:
chromium-reviews, lizeb+watch-custom-tabs_chromium.org, asvitkine+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "[Custom Tabs] Implement "Read It Later" Behind a Flag" This reverts commit ea63767b61ae1a8935b420685bbee58467b68b5b, which represents a feature that was disabled in M54 via field trial. BUG=620535 TBR=isherman@chromium.org Committed: https://crrev.com/631888b7a31ae659fba4f1641cd2e903ee6c483b Cr-Commit-Position: refs/heads/master@{#423682}

Patch Set 1 #

Patch Set 2 : compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -128 lines) Patch
M chrome/android/java/res/menu/custom_tabs_menu.xml View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java View 5 chunks +4 lines, -14 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java View 3 chunks +0 lines, -18 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabReparentingParams.java View 2 chunks +2 lines, -11 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java View 6 chunks +23 lines, -31 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabWindowManagerTest.java View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/android/chrome_feature_list.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/chrome_feature_list.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M testing/variations/fieldtrial_testing_config.json View 1 chunk +0 lines, -15 lines 0 comments Download
M tools/metrics/actions/actions.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 23 (15 generated)
Ian Wen
yusufo@chromium.org: Please review changes in custom tabs dfalcantara@chromium.org: Please review changes in other parts of ...
4 years, 2 months ago (2016-10-06 19:16:34 UTC) #3
Yusuf
lgtm
4 years, 2 months ago (2016-10-06 19:19:49 UTC) #4
gone
lgtm
4 years, 2 months ago (2016-10-06 20:03:56 UTC) #7
Ian Wen
TBR isherman@. Feel free to leave any comments, and I will fix them after the ...
4 years, 2 months ago (2016-10-06 21:07:49 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2393993005/20001
4 years, 2 months ago (2016-10-06 21:08:41 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-06 21:17:49 UTC) #20
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/631888b7a31ae659fba4f1641cd2e903ee6c483b Cr-Commit-Position: refs/heads/master@{#423682}
4 years, 2 months ago (2016-10-06 21:20:13 UTC) #22
Ilya Sherman
4 years, 2 months ago (2016-10-06 21:27:46 UTC) #23
Message was sent while issue was closed.
variations config and actions.xml lgtm

Powered by Google App Engine
This is Rietveld 408576698