Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2023)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java

Issue 2393993005: Revert "[Custom Tabs] Implement "Read It Later" Behind a Flag" (Closed)
Patch Set: compile Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java
index 5737a77a46620802b58114b566c5e5f7369791cf..e8b2a3c2b42406d814ef696f84e199800f164e89 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java
@@ -5,12 +5,10 @@
package org.chromium.chrome.browser.tabmodel;
import android.content.Intent;
-import android.os.Handler;
import android.text.TextUtils;
import org.chromium.base.SysUtils;
import org.chromium.base.TraceEvent;
-import org.chromium.chrome.R;
import org.chromium.chrome.browser.ChromeActivity;
import org.chromium.chrome.browser.IntentHandler;
import org.chromium.chrome.browser.ServiceTabLauncher;
@@ -27,13 +25,11 @@ import org.chromium.content_public.browser.WebContents;
import org.chromium.content_public.common.Referrer;
import org.chromium.ui.base.PageTransition;
import org.chromium.ui.base.WindowAndroid;
-import org.chromium.ui.widget.Toast;
/**
* This class creates various kinds of new tabs and adds them to the right {@link TabModel}.
*/
public class ChromeTabCreator extends TabCreatorManager.TabCreator {
- private static final int VISIBLE_DURATION_MS = 600;
private final ChromeActivity mActivity;
private final WindowAndroid mNativeWindow;
@@ -162,20 +158,6 @@ public class ChromeTabCreator extends TabCreatorManager.TabCreator {
}
mTabModel.addTab(tab, position, type);
-
- if (type == TabLaunchType.FROM_REPARENTING) {
- TabReparentingParams params = (TabReparentingParams) asyncParams;
- if (!params.shouldStayInChrome()) {
- new Handler().postDelayed(new Runnable() {
- @Override
- public void run() {
- mActivity.moveTaskToBack(true);
- Toast.makeText(mActivity, R.string.tab_sent_to_background,
- Toast.LENGTH_LONG).show();
- }
- }, VISIBLE_DURATION_MS);
- }
- }
return tab;
} finally {
TraceEvent.end("ChromeTabCreator.createNewTab");

Powered by Google App Engine
This is Rietveld 408576698