chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java - Issue 2393993005: Revert "[Custom Tabs] Implement "Read It Later" Behind a Flag"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java

Issue 2393993005: Revert "[Custom Tabs] Implement "Read It Later" Behind a Flag" (Closed)

Patch Set: compile Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java

index 58588bdc36e4c2deac5e0b8db5b565e215400124..5493d6bd13d73eace501f1ad3559207c6497bc76 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java

@@ -16,7 +16,6 @@ import org.chromium.base.BuildInfo;

import org.chromium.base.VisibleForTesting;

import org.chromium.chrome.R;

import org.chromium.chrome.browser.ChromeActivity;

-import org.chromium.chrome.browser.ChromeFeatureList;

import org.chromium.chrome.browser.appmenu.AppMenuPropertiesDelegate;

import org.chromium.chrome.browser.share.ShareHelper;

import org.chromium.chrome.browser.tab.Tab;

@@ -97,17 +96,11 @@ public class CustomTabAppMenuPropertiesDelegate extends AppMenuPropertiesDelegat

MenuItem iconRow = menu.findItem(R.id.icon_row_menu_id);

MenuItem openInChromeItem = menu.findItem(R.id.open_in_browser_id);

- MenuItem readItLaterItem = menu.findItem(R.id.read_it_later_id);

if (mIsMediaViewer) {

// Most of the menu items don't make sense when viewing media.

iconRow.setVisible(false);

openInChromeItem.setVisible(false);

- readItLaterItem.setVisible(false);

- } else if (ChromeFeatureList.isEnabled("ReadItLaterInMenu")) {

- // In the read-it-later experiment, Chrome will be the only browser to open the link

- openInChromeItem.setTitle(R.string.menu_open_in_chrome);

} else {

- readItLaterItem.setVisible(false);

try {

openInChromeItem.setTitle(mDefaultBrowserFetcher.get());

} catch (InterruptedException | ExecutionException e) {