Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2393643002: Resubmit issue 2221103002 to fix the iOS build by declaring the flag in (Closed)

Created:
4 years, 2 months ago by liyuqian
Modified:
4 years, 2 months ago
Reviewers:
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Resubmit issue 2221103002 to fix the iOS build by declaring the flag in SkCommonFlags.h TBR=reed@google.com,caryclark@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2393643002 Committed: https://skia.googlesource.com/skia/+/38911a7cb53474575e1cd1cb545902b50ee00889

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2136 lines, -49 lines) Patch
M bench/nanobench.cpp View 2 chunks +5 lines, -0 lines 0 comments Download
M dm/DM.cpp View 2 chunks +5 lines, -0 lines 0 comments Download
M gyp/core.gypi View 2 chunks +3 lines, -0 lines 0 comments Download
M samplecode/SampleApp.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
A src/core/SkAAAConstants.h View 1 chunk +220 lines, -0 lines 0 comments Download
A src/core/SkAnalyticEdge.h View 1 chunk +154 lines, -0 lines 0 comments Download
A src/core/SkAnalyticEdge.cpp View 1 chunk +245 lines, -0 lines 0 comments Download
M src/core/SkBlitter.cpp View 1 chunk +9 lines, -4 lines 0 comments Download
M src/core/SkEdge.h View 3 chunks +2 lines, -1 line 0 comments Download
M src/core/SkEdge.cpp View 4 chunks +16 lines, -3 lines 0 comments Download
M src/core/SkEdgeBuilder.h View 4 chunks +13 lines, -5 lines 0 comments Download
M src/core/SkEdgeBuilder.cpp View 8 chunks +149 lines, -36 lines 0 comments Download
M src/core/SkScan.h View 3 chunks +22 lines, -0 lines 0 comments Download
A src/core/SkScan_AAAPath.cpp View 1 chunk +1279 lines, -0 lines 0 comments Download
M src/core/SkScan_AntiPath.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M tools/flags/SkCommonFlags.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/flags/SkCommonFlags.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2393643002/1
4 years, 2 months ago (2016-10-04 17:59:09 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 18:23:25 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/38911a7cb53474575e1cd1cb545902b50ee00889

Powered by Google App Engine
This is Rietveld 408576698