Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2393633005: reflow comments in core/imagebitmap,core/html/track (Closed)

Created:
4 years, 2 months ago by Nico
Modified:
4 years, 2 months ago
Reviewers:
fs
CC:
fs, blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, gasubic, nessy, vcarbune.chromium
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

reflow comments in core/imagebitmap,core/html/track BUG=563793 Committed: https://crrev.com/515bb3084e26e5ffba3a7ffa6cae6d06063b911e Cr-Commit-Position: refs/heads/master@{#423327}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -93 lines) Patch
M third_party/WebKit/Source/core/html/track/AutomaticTrackSelection.cpp View 3 chunks +15 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/CueTimeline.h View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/CueTimeline.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/TextTrack.cpp View 7 chunks +21 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/TextTrackKindUserPreference.h View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/TextTrackList.cpp View 3 chunks +14 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp View 10 chunks +41 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/vtt/VTTParser.h View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp View 8 chunks +32 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/vtt/VTTRegion.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/vtt/VTTScanner.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/track/vtt/VTTTokenizer.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Nico
4 years, 2 months ago (2016-10-05 20:10:37 UTC) #3
fs
lgtm
4 years, 2 months ago (2016-10-05 20:18:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2393633005/1
4 years, 2 months ago (2016-10-05 20:20:22 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 23:00:10 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 23:03:24 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/515bb3084e26e5ffba3a7ffa6cae6d06063b911e
Cr-Commit-Position: refs/heads/master@{#423327}

Powered by Google App Engine
This is Rietveld 408576698