Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Unified Diff: third_party/WebKit/Source/core/html/track/AutomaticTrackSelection.cpp

Issue 2393633005: reflow comments in core/imagebitmap,core/html/track (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/track/CueTimeline.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/track/AutomaticTrackSelection.cpp
diff --git a/third_party/WebKit/Source/core/html/track/AutomaticTrackSelection.cpp b/third_party/WebKit/Source/core/html/track/AutomaticTrackSelection.cpp
index 03d65b3df75900309cb851f079bb52fd2db2a375..ef7cc895e724b427d8d0a5b9295df000ac3c072f 100644
--- a/third_party/WebKit/Source/core/html/track/AutomaticTrackSelection.cpp
+++ b/third_party/WebKit/Source/core/html/track/AutomaticTrackSelection.cpp
@@ -87,10 +87,11 @@ void AutomaticTrackSelection::performAutomaticTextTrackSelection(
if (textTrack->kind() == preferredTrackKind())
trackScore += 1;
if (trackScore) {
- // * If the text track kind is subtitles or captions and the user has indicated an interest in having a
- // track with this text track kind, text track language, and text track label enabled, and there is no
- // other text track in the media element's list of text tracks with a text track kind of either subtitles
- // or captions whose text track mode is showing
+ // * If the text track kind is subtitles or captions and the user has
+ // indicated an interest in having a track with this text track kind, text
+ // track language, and text track label enabled, and there is no other
+ // text track in the media element's list of text tracks with a text track
+ // kind of either subtitles or captions whose text track mode is showing
// Let the text track mode be showing.
if (trackScore > highestTrackScore) {
preferredTrack = textTrack;
@@ -102,8 +103,9 @@ void AutomaticTrackSelection::performAutomaticTextTrackSelection(
if (!fallbackTrack)
fallbackTrack = textTrack;
} else if (!group.visibleTrack && !defaultTrack && textTrack->isDefault()) {
- // * If the track element has a default attribute specified, and there is no other text track in the media
- // element's list of text tracks whose text track mode is showing or showing by default
+ // * If the track element has a default attribute specified, and there is
+ // no other text track in the media element's list of text tracks whose
+ // text track mode is showing or showing by default
// Let the text track mode be showing by default.
defaultTrack = textTrack;
}
@@ -186,12 +188,13 @@ void AutomaticTrackSelection::perform(TextTrackList& textTracks) {
if (!currentGroup->defaultTrack && textTrack->isDefault())
currentGroup->defaultTrack = textTrack;
- // Do not add this track to the group if it has already been automatically configured
- // as we only want to perform selection once per track so that adding another track
- // after the initial configuration doesn't reconfigure every track - only those that
- // should be changed by the new addition. For example all metadata tracks are
- // disabled by default, and we don't want a track that has been enabled by script
- // to be disabled automatically when a new metadata track is added later.
+ // Do not add this track to the group if it has already been automatically
+ // configured as we only want to perform selection once per track so that
+ // adding another track after the initial configuration doesn't reconfigure
+ // every track - only those that should be changed by the new addition. For
+ // example all metadata tracks are disabled by default, and we don't want a
+ // track that has been enabled by script to be disabled automatically when a
+ // new metadata track is added later.
if (textTrack->hasBeenConfigured())
continue;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/track/CueTimeline.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698