blimp/client/app/android/java/res/layout/text_input_popup.xml - Issue 2393443004: Blimp: Added spinner to text input dialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/app/android/java/res/layout/text_input_popup.xml

Issue 2393443004: Blimp: Added spinner to text input dialog (Closed)

Patch Set: nits Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « blimp/client/app/android/java/res/drawable/dotted_line.xml ('k') | blimp/client/app/android/java/res/layout/web_input_bottom_panel.xml » ('j') | blimp/engine/feature/engine_render_widget_feature.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/client/app/android/java/res/layout/text_input_popup.xml

diff --git a/blimp/client/app/android/java/res/layout/text_input_popup.xml b/blimp/client/app/android/java/res/layout/text_input_popup.xml

index 456b2c10edc7b4a7ebc87e779ae92a21c76d5212..bfd4635e53395add757f3f1c83f190b52a948bc3 100644

--- a/blimp/client/app/android/java/res/layout/text_input_popup.xml

+++ b/blimp/client/app/android/java/res/layout/text_input_popup.xml

@@ -3,16 +3,35 @@

Use of this source code is governed by a BSD-style license that can be

found in the LICENSE file.

-->

-<FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"

- android:layout_width="wrap_content"

- android:layout_height="wrap_content"

- android:gravity="start">

+<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"

+ android:layout_width="match_parent"

+ android:layout_height="wrap_content">

+ <TextView

+ android:id="@+id/label"

+ android:layout_width="match_parent"

+ android:layout_height="wrap_content"

+ android:layout_marginTop="17dp"

+ android:layout_marginStart="24dp"

+ android:fontFamily="sans-serif-medium"

+ android:textColor="@color/disabled_text_color"

+ android:textSize="12sp"/>

<org.chromium.blimp.core.contents.input.ImeEditText

android:id="@+id/ime_edit_text"

android:inputType="text"

android:layout_width="match_parent"

android:layout_height="wrap_content"

- android:textSize="18sp"

- android:singleLine="true"

- android:layout_marginTop="10dp"/>

-</FrameLayout>

+ android:layout_below="@+id/label"

+ android:layout_marginTop= "4dp"

+ android:layout_marginStart="24dp"

+ android:layout_marginEnd="24dp"

+ android:fontFamily="sans-serif"

+ android:textSize="16sp"

+ android:singleLine="true"/>

+ <org.chromium.blimp.core.contents.input.WebInputConfirmationPanel

+ android:id="@+id/submit_panel"

+ android:layout_width="match_parent"

+ android:layout_height="wrap_content"

+ android:layout_below="@+id/ime_edit_text"

+ android:layout_marginBottom="12dp"

+ android:layout_marginTop="19dp"/>

+</RelativeLayout>