Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2480)

Unified Diff: blimp/engine/feature/engine_render_widget_feature.cc

Issue 2393443004: Blimp: Added spinner to text input dialog (Closed)
Patch Set: nits Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/engine/feature/engine_render_widget_feature.h ('k') | build/android/lint/suppressions.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/engine/feature/engine_render_widget_feature.cc
diff --git a/blimp/engine/feature/engine_render_widget_feature.cc b/blimp/engine/feature/engine_render_widget_feature.cc
index 611427d10f003210b1aa1a1a3b73bf14b48ed528..7de5e8b39c254e8afce7e2232790e6e07d8469e4 100644
--- a/blimp/engine/feature/engine_render_widget_feature.cc
+++ b/blimp/engine/feature/engine_render_widget_feature.cc
@@ -23,7 +23,7 @@ namespace blimp {
namespace engine {
EngineRenderWidgetFeature::EngineRenderWidgetFeature(SettingsManager* settings)
- : settings_manager_(settings) {
+ : settings_manager_(settings), weak_factory_(this) {
DCHECK(settings_manager_);
settings_manager_->AddObserver(this);
}
@@ -233,6 +233,15 @@ void EngineRenderWidgetFeature::ProcessMessage(
if (render_widget_host && render_widget_host->GetView()) {
SetTextFromIME(render_widget_host, message->ime().ime_text(),
message->ime().auto_submit());
+
+ // TODO(shaktisahu): Remove this fake HIDE_IME request once the blimp
+ // IME design is completed (crbug/661328).
+ base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(
+ FROM_HERE,
+ base::Bind(&EngineRenderWidgetFeature::SendHideImeRequest,
+ weak_factory_.GetWeakPtr(), target_tab_id,
+ render_widget_host),
+ base::TimeDelta::FromMilliseconds(1500));
Wez 2016/11/07 22:51:52 What's the rationale for the delay here?
}
break;
default:
« no previous file with comments | « blimp/engine/feature/engine_render_widget_feature.h ('k') | build/android/lint/suppressions.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698