blimp/client/app/android/java/res/layout/text_input_popup.xml - Issue 2393443004: Blimp: Added spinner to text input dialog

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: blimp/client/app/android/java/res/layout/text_input_popup.xml

Issue 2393443004: Blimp: Added spinner to text input dialog (Closed)

Patch Set: nits Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « blimp/client/app/android/java/res/drawable/dotted_line.xml ('k') | blimp/client/app/android/java/res/layout/web_input_bottom_panel.xml » ('j') | blimp/engine/feature/engine_render_widget_feature.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file.	4 found in the LICENSE file.

5 -->	5 -->

6 <FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"	6 <RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"

7 android:layout_width="wrap_content"	7 android:layout_width="match_parent"

8 android:layout_height="wrap_content"	8 android:layout_height="wrap_content">

9 android:gravity="start">	9 <TextView

	10 android:id="@+id/label"

	11 android:layout_width="match_parent"

	12 android:layout_height="wrap_content"

	13 android:layout_marginTop="17dp"

	14 android:layout_marginStart="24dp"

	15 android:fontFamily="sans-serif-medium"

	16 android:textColor="@color/disabled_text_color"

	17 android:textSize="12sp"/>

10 <org.chromium.blimp.core.contents.input.ImeEditText	18 <org.chromium.blimp.core.contents.input.ImeEditText

11 android:id="@+id/ime_edit_text"	19 android:id="@+id/ime_edit_text"

12 android:inputType="text"	20 android:inputType="text"

13 android:layout_width="match_parent"	21 android:layout_width="match_parent"

14 android:layout_height="wrap_content"	22 android:layout_height="wrap_content"

15 android:textSize="18sp"	23 android:layout_below="@+id/label"

16 android:singleLine="true"	24 android:layout_marginTop= "4dp"

17 android:layout_marginTop="10dp"/>	25 android:layout_marginStart="24dp"

18 </FrameLayout>	26 android:layout_marginEnd="24dp"

	27 android:fontFamily="sans-serif"

	28 android:textSize="16sp"

	29 android:singleLine="true"/>

	30 <org.chromium.blimp.core.contents.input.WebInputConfirmationPanel

	31 android:id="@+id/submit_panel"

	32 android:layout_width="match_parent"

	33 android:layout_height="wrap_content"

	34 android:layout_below="@+id/ime_edit_text"

	35 android:layout_marginBottom="12dp"

	36 android:layout_marginTop="19dp"/>

	37 </RelativeLayout>

OLD	NEW