Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 2393133004: reflow comments in core/html/shadow (Closed)

Created:
4 years, 2 months ago by Nico
Modified:
4 years, 2 months ago
Reviewers:
fs
CC:
fs, blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, gasubic, mlamouri+watch-blink_chromium.org, nessy, Srirama, vcarbune.chromium
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

reflow comments in core/html/shadow BUG=563793 Committed: https://crrev.com/fa6ea29dbd5323d2138abf686074f75b14919be7 Cr-Commit-Position: refs/heads/master@{#423335}

Patch Set 1 #

Total comments: 2

Patch Set 2 : comments (heh!) #

Patch Set 3 : oops #

Messages

Total messages: 15 (9 generated)
Nico
4 years, 2 months ago (2016-10-05 20:32:30 UTC) #3
fs
lgtm https://codereview.chromium.org/2393133004/diff/1/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp File third_party/WebKit/Source/core/html/shadow/MediaControls.cpp (right): https://codereview.chromium.org/2393133004/diff/1/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp#newcode194 third_party/WebKit/Source/core/html/shadow/MediaControls.cpp:194: // | (-internal-media-controls-text-track-list-kind-subtitles) uNit: Could drop this pipe
4 years, 2 months ago (2016-10-05 20:52:08 UTC) #5
Nico
Thanks! https://codereview.chromium.org/2393133004/diff/1/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp File third_party/WebKit/Source/core/html/shadow/MediaControls.cpp (right): https://codereview.chromium.org/2393133004/diff/1/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp#newcode194 third_party/WebKit/Source/core/html/shadow/MediaControls.cpp:194: // | (-internal-media-controls-text-track-list-kind-subtitles) On 2016/10/05 20:52:08, fs wrote: ...
4 years, 2 months ago (2016-10-05 21:19:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2393133004/40001
4 years, 2 months ago (2016-10-05 21:21:06 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-05 23:27:10 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 23:29:47 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fa6ea29dbd5323d2138abf686074f75b14919be7
Cr-Commit-Position: refs/heads/master@{#423335}

Powered by Google App Engine
This is Rietveld 408576698