Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Side by Side Diff: third_party/WebKit/Source/core/html/shadow/DateTimeFieldElement.cpp

Issue 2393133004: reflow comments in core/html/shadow (Closed)
Patch Set: oops Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 return; 82 return;
83 83
84 if (isDisabled() || isFieldOwnerDisabled()) 84 if (isDisabled() || isFieldOwnerDisabled())
85 return; 85 return;
86 86
87 const String& key = keyboardEvent->key(); 87 const String& key = keyboardEvent->key();
88 88
89 if (key == "ArrowLeft") { 89 if (key == "ArrowLeft") {
90 if (!m_fieldOwner) 90 if (!m_fieldOwner)
91 return; 91 return;
92 // FIXME: We'd like to use FocusController::advanceFocus(FocusDirectionLeft, ...) 92 // FIXME: We'd like to use FocusController::advanceFocus(FocusDirectionLeft,
93 // but it doesn't work for shadow nodes. webkit.org/b/104650 93 // ...) but it doesn't work for shadow nodes. webkit.org/b/104650
94 if (!localeForOwner().isRTL() && m_fieldOwner->focusOnPreviousField(*this)) 94 if (!localeForOwner().isRTL() && m_fieldOwner->focusOnPreviousField(*this))
95 keyboardEvent->setDefaultHandled(); 95 keyboardEvent->setDefaultHandled();
96 return; 96 return;
97 } 97 }
98 98
99 if (key == "ArrowRight") { 99 if (key == "ArrowRight") {
100 if (!m_fieldOwner) 100 if (!m_fieldOwner)
101 return; 101 return;
102 // FIXME: We'd like to use FocusController::advanceFocus(FocusDirectionRight , ...) 102 // FIXME: We'd like to use
103 // FocusController::advanceFocus(FocusDirectionRight, ...)
103 // but it doesn't work for shadow nodes. webkit.org/b/104650 104 // but it doesn't work for shadow nodes. webkit.org/b/104650
104 if (!localeForOwner().isRTL() && m_fieldOwner->focusOnNextField(*this)) 105 if (!localeForOwner().isRTL() && m_fieldOwner->focusOnNextField(*this))
105 keyboardEvent->setDefaultHandled(); 106 keyboardEvent->setDefaultHandled();
106 return; 107 return;
107 } 108 }
108 109
109 if (isFieldOwnerReadOnly()) 110 if (isFieldOwnerReadOnly())
110 return; 111 return;
111 112
112 if (key == "ArrowDown") { 113 if (key == "ArrowDown") {
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
218 219
219 if (eventBehavior == DispatchEvent && m_fieldOwner) 220 if (eventBehavior == DispatchEvent && m_fieldOwner)
220 m_fieldOwner->fieldValueChanged(); 221 m_fieldOwner->fieldValueChanged();
221 } 222 }
222 223
223 int DateTimeFieldElement::valueForARIAValueNow() const { 224 int DateTimeFieldElement::valueForARIAValueNow() const {
224 return valueAsInteger(); 225 return valueAsInteger();
225 } 226 }
226 227
227 } // namespace blink 228 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698