Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1740)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 239283002: DevTools: goto-line functionality should not change selected uisourcecode (Closed)

Created:
6 years, 8 months ago by lushnikov
Modified:
6 years, 8 months ago
Reviewers:
vsevik, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: goto-line functionality should not change selected uisourcecode BUG=363597 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171764

Patch Set 1 #

Patch Set 2 : add testcase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -10 lines) Patch
M LayoutTests/inspector/filtered-item-selection-dialog-filtering.html View 1 4 chunks +11 lines, -9 lines 0 comments Download
M LayoutTests/inspector/filtered-item-selection-dialog-filtering-expected.txt View 1 1 chunk +11 lines, -0 lines 0 comments Download
M Source/devtools/front_end/FilteredItemSelectionDialog.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
lushnikov
ptal
6 years, 8 months ago (2014-04-15 15:14:52 UTC) #1
pfeldman
lgtm
6 years, 8 months ago (2014-04-15 15:34:37 UTC) #2
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 8 months ago (2014-04-15 15:35:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/239283002/1
6 years, 8 months ago (2014-04-15 15:35:22 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-15 16:18:21 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 8 months ago (2014-04-15 16:18:21 UTC) #6
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 8 months ago (2014-04-15 16:38:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/239283002/1
6 years, 8 months ago (2014-04-15 16:39:42 UTC) #8
vsevik
I think this requires a test
6 years, 8 months ago (2014-04-15 16:43:18 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-15 17:09:17 UTC) #10
commit-bot: I haz the power
List of reviewers changed. vsevik@chromium.org did a drive-by without LGTM'ing!
6 years, 8 months ago (2014-04-15 17:09:17 UTC) #11
lushnikov
added testcase
6 years, 8 months ago (2014-04-16 11:58:37 UTC) #12
vsevik
lgtm
6 years, 8 months ago (2014-04-16 11:58:51 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/239283002/20001
6 years, 8 months ago (2014-04-16 11:59:06 UTC) #14
commit-bot: I haz the power
6 years, 8 months ago (2014-04-16 14:20:55 UTC) #15
Message was sent while issue was closed. 
Change committed as 171764

Powered by Google App Engine
This is Rietveld 408576698