Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: LayoutTests/inspector/filtered-item-selection-dialog-filtering.html

Issue 239283002: DevTools: goto-line functionality should not change selected uisourcecode (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: add testcase Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/inspector/filtered-item-selection-dialog-filtering-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/inspector/filtered-item-selection-dialog-filtering.html
diff --git a/LayoutTests/inspector/filtered-item-selection-dialog-filtering.html b/LayoutTests/inspector/filtered-item-selection-dialog-filtering.html
index 810be3f0d437cc2a94daf97a46f84c50805a45c5..5f1176a49360d3cd0ef438e96a8101d82a8dd150 100644
--- a/LayoutTests/inspector/filtered-item-selection-dialog-filtering.html
+++ b/LayoutTests/inspector/filtered-item-selection-dialog-filtering.html
@@ -8,9 +8,8 @@ function test()
WebInspector.inspectorView.showPanel("sources");
var overridenInput = [];
- var overridenTitle = [];
var overridenQuery = "";
- var overridenScores = [];
+ var overrideShowMatchingItems = true;
function StubDelegate()
{
@@ -18,26 +17,27 @@ function test()
}
StubDelegate.prototype = {
itemKeyAt: function(itemIndex) { return overridenInput[itemIndex]; },
- itemScoreAt: function(itemIndex) { return overridenScores[itemIndex] || 0; },
+ itemScoreAt: function(itemIndex) { return 0; },
itemCount: function() { return overridenInput.length; },
- selectItem: function(itemIndex, promptValue) { },
+ selectItem: function(itemIndex, promptValue)
+ {
+ InspectorTest.addResult("Selected item index: " + itemIndex);
+ },
rewriteQuery: function(query) { return overridenQuery; },
+ shouldShowMatchingItems: function() { return overrideShowMatchingItems; },
__proto__: WebInspector.SelectionDialogContentProvider.prototype
}
var overridenInput = [];
- var overridenTitle = [];
var overridenQuery = "";
- var overridenScores = [];
var delegate = new StubDelegate();
- function checkQuery(title, query, input, titles, scores)
+ function checkQuery(title, query, input, hideMatchingItems)
{
overridenInput = input;
overridenQuery = query;
- overridenTitles = titles || [];
- overridenScores = scores || [];
+ overrideShowMatchingItems = !hideMatchingItems;
InspectorTest.addResult("\n" + title);
InspectorTest.addResult("Query:" + JSON.stringify(query));
@@ -50,6 +50,7 @@ function test()
for (var i = 0; i < items.length; ++i)
output.push(delegate.itemKeyAt(items[i]));
InspectorTest.addResult("Output:" + JSON.stringify(output));
+ filteredSelectionDialog.onEnter();
}
checkQuery("Empty query matches everything", "", ["a", "bc"]);
@@ -57,6 +58,7 @@ function test()
checkQuery("Case insensitive matching", "ab", ["abc", "bac", "a_B"]);
checkQuery("Duplicate symbols in query", "aab", ["abab", "abaa", "caab", "baac", "fooaab"]);
checkQuery("Dangerous input escaping", "^[]{}()\\.$*+?|", ["^[]{}()\\.$*+?|", "0123456789abcdef"]);
+ checkQuery("Item index is not reported in go-to line", ":1", [":1:2:3.js"], true);
InspectorTest.completeTest();
}
« no previous file with comments | « no previous file | LayoutTests/inspector/filtered-item-selection-dialog-filtering-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698