Source/devtools/front_end/FilteredItemSelectionDialog.js - Issue 239283002: DevTools: goto-line functionality should not change selected uisourcecode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/FilteredItemSelectionDialog.js

Issue 239283002: DevTools: goto-line functionality should not change selected uisourcecode (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: add testcase Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/devtools/front_end/FilteredItemSelectionDialog.js

diff --git a/Source/devtools/front_end/FilteredItemSelectionDialog.js b/Source/devtools/front_end/FilteredItemSelectionDialog.js

index 6543075a8dcd9c1ff2d7d05bfca4a5d53e453c50..2a4c7342e43ed1ca1c9a206cbdbc2ff1adbdd103 100644

--- a/Source/devtools/front_end/FilteredItemSelectionDialog.js

+++ b/Source/devtools/front_end/FilteredItemSelectionDialog.js

@@ -118,7 +118,7 @@ WebInspector.FilteredItemSelectionDialog.prototype = {

{

if (!this._delegate.itemCount())

return;

- var selectedIndex = this._selectedIndexInFiltered < this._filteredItems.length ? this._filteredItems[this._selectedIndexInFiltered] : null;

+ var selectedIndex = this._shouldShowMatchingItems() && this._selectedIndexInFiltered < this._filteredItems.length ? this._filteredItems[this._selectedIndexInFiltered] : null;

this._delegate.selectItem(selectedIndex, this._promptElement.value.trim());

« no previous file with comments | « LayoutTests/inspector/filtered-item-selection-dialog-filtering-expected.txt ('k') | no next file » | no next file with comments »