Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(857)

Issue 2391993006: Move handling of 'attributeType' to SVGAnimateElement (Closed)

Created:
4 years, 2 months ago by fs
Modified:
4 years, 2 months ago
Reviewers:
pdr., Stephen Chennney
CC:
fs, darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move handling of 'attributeType' to SVGAnimateElement Another animation property that applies only to the SVGAnimateElement part/subtree of the element hierarchy. Move it down for continued "unlocking" of the structure. BUG=641437 Committed: https://crrev.com/3e407a5549c3001e11be6f99e42ec5c484442339 Cr-Commit-Position: refs/heads/master@{#423467}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -69 lines) Patch
M third_party/WebKit/Source/core/svg/SVGAnimateElement.h View 3 chunks +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp View 3 chunks +54 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimationElement.h View 5 chunks +2 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimationElement.cpp View 5 chunks +0 lines, -51 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
fs
4 years, 2 months ago (2016-10-05 21:31:22 UTC) #4
pdr.
On 2016/10/05 at 21:31:22, fs wrote: > LGTM
4 years, 2 months ago (2016-10-05 22:34:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2391993006/1
4 years, 2 months ago (2016-10-06 07:19:56 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 07:25:43 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 07:27:12 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3e407a5549c3001e11be6f99e42ec5c484442339
Cr-Commit-Position: refs/heads/master@{#423467}

Powered by Google App Engine
This is Rietveld 408576698