Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(829)

Unified Diff: third_party/WebKit/Source/core/svg/SVGAnimationElement.h

Issue 2391993006: Move handling of 'attributeType' to SVGAnimateElement (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/SVGAnimationElement.h
diff --git a/third_party/WebKit/Source/core/svg/SVGAnimationElement.h b/third_party/WebKit/Source/core/svg/SVGAnimationElement.h
index bbb0d038d8719b8c686f1a1982f22cccb735c58e..2e0863733a3d8ab9bda945219abcc67c3bd7600e 100644
--- a/third_party/WebKit/Source/core/svg/SVGAnimationElement.h
+++ b/third_party/WebKit/Source/core/svg/SVGAnimationElement.h
@@ -118,9 +118,6 @@ class CORE_EXPORT SVGAnimationElement : public SVGSMILElement {
const AtomicString&) override;
void svgAttributeChanged(const QualifiedName&) override;
- enum AttributeType { AttributeTypeCSS, AttributeTypeXML, AttributeTypeAuto };
- AttributeType getAttributeType() const { return m_attributeType; }
-
String toValue() const;
String byValue() const;
String fromValue() const;
@@ -131,13 +128,6 @@ class CORE_EXPORT SVGAnimationElement : public SVGSMILElement {
unsigned repeat,
SVGSMILElement* resultElement) override;
- void setTargetElement(SVGElement*) override;
- void setAttributeName(const QualifiedName&) override;
-
- bool hasInvalidCSSAttributeType() const {
- return m_hasInvalidCSSAttributeType;
- }
-
virtual void updateAnimationMode();
void setAnimationMode(AnimationMode animationMode) {
m_animationMode = animationMode;
@@ -151,13 +141,10 @@ class CORE_EXPORT SVGAnimationElement : public SVGSMILElement {
// http://www.w3.org/TR/SVG/animate.html#ValuesAttribute .
static bool parseValues(const String&, Vector<String>& result);
- private:
- bool isValid() const final { return SVGTests::isValid(); }
-
void animationAttributeChanged() override;
- void setAttributeType(const AtomicString&);
- void checkInvalidCSSAttributeType();
+ private:
+ bool isValid() const final { return SVGTests::isValid(); }
virtual bool calculateToAtEndOfDurationValue(
const String& toAtEndOfDurationString) = 0;
@@ -191,7 +178,6 @@ class CORE_EXPORT SVGAnimationElement : public SVGSMILElement {
bool m_animationValid;
- AttributeType m_attributeType;
Vector<String> m_values;
// FIXME: We should probably use doubles for this, but there's no point
// making such a change unless all SVG logic for sampling animations is
@@ -201,7 +187,6 @@ class CORE_EXPORT SVGAnimationElement : public SVGSMILElement {
Vector<gfx::CubicBezier> m_keySplines;
String m_lastValuesAnimationFrom;
String m_lastValuesAnimationTo;
- bool m_hasInvalidCSSAttributeType;
CalcMode m_calcMode;
AnimationMode m_animationMode;
};
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp ('k') | third_party/WebKit/Source/core/svg/SVGAnimationElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698