Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Unified Diff: third_party/WebKit/Source/core/svg/SVGAnimateElement.h

Issue 2391993006: Move handling of 'attributeType' to SVGAnimateElement (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/svg/SVGAnimateElement.h
diff --git a/third_party/WebKit/Source/core/svg/SVGAnimateElement.h b/third_party/WebKit/Source/core/svg/SVGAnimateElement.h
index 816363f85471dd64954ef30d68774f95e2575e8c..0aecbddc5902b67ceb15230f4f1e21622e0f6ff1 100644
--- a/third_party/WebKit/Source/core/svg/SVGAnimateElement.h
+++ b/third_party/WebKit/Source/core/svg/SVGAnimateElement.h
@@ -71,9 +71,17 @@ class CORE_EXPORT SVGAnimateElement : public SVGAnimationElement {
const String& toString) final;
bool isAdditive() final;
+ void parseAttribute(const QualifiedName&,
+ const AtomicString&,
+ const AtomicString&) override;
+ void svgAttributeChanged(const QualifiedName&) override;
+
void setTargetElement(SVGElement*) final;
void setAttributeName(const QualifiedName&) final;
+ enum AttributeType { AttributeTypeCSS, AttributeTypeXML, AttributeTypeAuto };
+ AttributeType getAttributeType() const { return m_attributeType; }
+
FRIEND_TEST_ALL_PREFIXES(UnsafeSVGAttributeSanitizationTest,
stringsShouldNotSupportAddition);
@@ -91,6 +99,12 @@ class CORE_EXPORT SVGAnimateElement : public SVGAnimationElement {
SVGElement* targetElement,
const QualifiedName& attributeName);
+ void setAttributeType(const AtomicString&);
+
+ void checkInvalidCSSAttributeType();
+ bool hasInvalidCSSAttributeType() const {
+ return m_hasInvalidCSSAttributeType;
+ }
bool hasValidAttributeType() override;
SVGPropertyBase* adjustForInheritance(SVGPropertyBase*,
@@ -105,6 +119,8 @@ class CORE_EXPORT SVGAnimateElement : public SVGAnimationElement {
AnimatedPropertyValueType m_fromPropertyValueType;
AnimatedPropertyValueType m_toPropertyValueType;
+ AttributeType m_attributeType;
+ bool m_hasInvalidCSSAttributeType;
};
inline bool isSVGAnimateElement(const SVGElement& element) {
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698