Reformat comments in core/layout up until LayoutBox

Reformat comments in core/layout up until LayoutBox

BUG=563793
R=ikilpatrick@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/f88ea2d39f753432656ab06970e7792f012b9104

[eae, 2016-10-04 16:24:09]

The CQ bit was checked by eae@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 16:24:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 16:33:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 16:33:55]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[ikilpatrick, 2016-10-04 16:39:02]

lgtm

https://codereview.chromium.org/2391893004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/ColumnBalancer.cpp (right):

https://codereview.chromium.org/2391893004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ColumnBalancer.cpp:43: // break-before
value of the next in-flow block-level sibling.
bad.

https://codereview.chromium.org/2391893004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ColumnBalancer.cpp:68: // cannot just
bad.

https://codereview.chromium.org/2391893004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ColumnBalancer.cpp:83: // multicol
bad.

https://codereview.chromium.org/2391893004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ColumnBalancer.cpp:161: // orphans and
widows, and that may affect the minimum page height.
bad.

https://codereview.chromium.org/2391893004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ColumnBalancer.cpp:221: // overflow area
shouldn't affect column balancing.
bad.

https://codereview.chromium.org/2391893004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ColumnBalancer.cpp:247: // the end of the
multicol container.
bad.

https://codereview.chromium.org/2391893004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/CounterNode.cpp (right):

https://codereview.chromium.org/2391893004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/CounterNode.cpp:199:
m_rootLayoutObject->invalidate();  // This makes m_rootLayoutObject point to
nit. comment should be above line.

https://codereview.chromium.org/2391893004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/FragmentainerIterator.cpp (right):

https://codereview.chromium.org/2391893004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/FragmentainerIterator.cpp:122: setAtEnd();
 // This fragmentainer group doesn't intersect with the range
comment above?

https://codereview.chromium.org/2391893004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/HitTestResult.h (right):

https://codereview.chromium.org/2391893004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/HitTestResult.h:205: // determine where
inside the layoutObject we hit on subsequent operations.
very bad.

https://codereview.chromium.org/2391893004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutBox.cpp (right):

https://codereview.chromium.org/2391893004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutBox.cpp:1088:
AutoscrollController::noMiddleClickAutoscrollRadius)  // at the center we
icky.

https://codereview.chromium.org/2391893004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutBox.cpp:2096:
!m_rareData->m_spannerPlaceholder);  // not expected to change
more icky.

[eae, 2016-10-04 16:48:06]

The CQ bit was checked by eae@chromium.org

[eae, 2016-10-04 16:48:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
ikilpatrick@chromium.org
Link to the patchset: https://codereview.chromium.org/2391893004/#ps20001
(title: "Address reviewer comments + git cl format")

[eae, 2016-10-04 16:48:15]

Thanks Ian!

[commit-bot: I haz the power, 2016-10-04 16:48:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 17:01:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 17:01:09]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[eae, 2016-10-04 17:35:23]

The CQ bit was checked by eae@chromium.org

[eae, 2016-10-04 17:35:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
ikilpatrick@chromium.org
Link to the patchset: https://codereview.chromium.org/2391893004/#ps40001
(title: "Rebase w/HEAD")

[commit-bot: I haz the power, 2016-10-04 17:35:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 18:05:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 18:05:44]

Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[eae, 2016-10-04 18:20:09]

The CQ bit was checked by eae@chromium.org

[eae, 2016-10-04 18:20:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
ikilpatrick@chromium.org
Link to the patchset: https://codereview.chromium.org/2391893004/#ps60001
(title: "Fix typo")

[commit-bot: I haz the power, 2016-10-04 18:20:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 19:34:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 19:34:57]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[eae, 2016-10-04 20:01:56]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2016-10-04 20:03:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 20:48:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 20:49:00]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[ikilpatrick, 2016-10-04 20:51:34]

The CQ bit was checked by ikilpatrick@chromium.org

[commit-bot: I haz the power, 2016-10-04 20:52:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 20:58:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 20:58:42]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[commit-bot: I haz the power, 2016-10-04 21:36:11]

Description was changed from

==========
Reformat comments in core/layout up until LayoutBox

BUG=563793
R=ikilpatrick@chromium.org
==========

to

==========
Reformat comments in core/layout up until LayoutBox

BUG=563793
R=ikilpatrick@chromium.org

Committed: https://crrev.com/f88ea2d39f753432656ab06970e7792f012b9104
Cr-Commit-Position: refs/heads/master@{#422937}
==========

[commit-bot: I haz the power, 2016-10-04 21:36:14]

Patchset 5 (id:??) landed as
https://crrev.com/f88ea2d39f753432656ab06970e7792f012b9104
Cr-Commit-Position: refs/heads/master@{#422937}

[eae, 2016-10-04 21:38:07]

Description was changed from

==========
Reformat comments in core/layout up until LayoutBox

BUG=563793
R=ikilpatrick@chromium.org

Committed: https://crrev.com/f88ea2d39f753432656ab06970e7792f012b9104
Cr-Commit-Position: refs/heads/master@{#422937}
==========

to

==========
Reformat comments in core/layout up until LayoutBox

BUG=563793
R=ikilpatrick@chromium.org

Committed:
https://chromium.googlesource.com/chromium/src/+/f88ea2d39f753432656ab06970e7...
==========

[eae, 2016-10-04 21:38:08]

Committed patchset #5 (id:80001) manually as
f88ea2d39f753432656ab06970e7792f012b9104 (presubmit successful).

[imcheng, 2016-10-05 01:10:52]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2395683002/ by imcheng@chromium.org.

The reason for reverting is: May have broken webkit_tests:

https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac1...
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linu...
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win1....

[imcheng, 2016-10-05 01:30:35]

imcheng@chromium.org changed reviewers:
+ imcheng@chromium.org

[imcheng, 2016-10-05 01:30:36]

FWIW, L478 in HitTestResult.cpp may have unintentionally commented out some
code. I am not sure if it is the only place though.