Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(19)

Issue 2391793002: Mac: Fix bugs in Sierra color fix (Closed)

Created:
2 years, 8 months ago by ccameron
Modified:
2 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Mac: Fix bugs in Sierra color fix The previous fix uncondiontally replaced populated the solid color IOSurface and updated the contents_rect for all layers on Sierra, instead of just doing it for the ones without IOSurfaces. Fix this bug, parameterize whether or not we are using this workaround, and add tests for both code paths. BUG=633805 Review-Url: https://codereview.chromium.org/2387653004 Cr-Commit-Position: refs/heads/master@{#422281} (cherry picked from commit 496c26b5cc3983f40b65729d8fa8bbd4a9951c71) Mac: Fix Sierra solid color layer color-mismatch Sierra treats the color correction of IOSurface-backed layers and solid color layers differently. To ensure that behavior is consistent, do not use solid color layers, rather, in such cases, use an 16x16 IOSurface that is initialized to the solid color. BUG=633805 Review-Url: https://codereview.chromium.org/2378423002 Cr-Commit-Position: refs/heads/master@{#421899} (cherry picked from commit 318395caaf3a43683a41d09e65050649d5fedf27) Committed: https://chromium.googlesource.com/chromium/src/+/a01116d528eb834b2580328817db8105ef0f59e8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+505 lines, -371 lines) Patch
M ui/accelerated_widget_mac/ca_layer_tree_coordinator.mm View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/accelerated_widget_mac/ca_layer_tree_unittest_mac.mm View 11 chunks +386 lines, -361 lines 0 comments Download
M ui/accelerated_widget_mac/ca_renderer_layer_tree.h View 5 chunks +9 lines, -1 line 0 comments Download
M ui/accelerated_widget_mac/ca_renderer_layer_tree.mm View 9 chunks +107 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
ccameron
2 years, 8 months ago (2016-10-03 22:24:04 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a01116d528eb834b2580328817db8105ef0f59e8.

Powered by Google App Engine
This is Rietveld 408576698