Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 2378423002: Mac: Fix Sierra solid color layer color-mismatch (Closed)

Created:
2 years, 8 months ago by ccameron
Modified:
2 years, 8 months ago
Reviewers:
erikchen
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac: Fix Sierra solid color layer color-mismatch Sierra treats the color correction of IOSurface-backed layers and solid color layers differently. To ensure that behavior is consistent, do not use solid color layers, rather, in such cases, use an 16x16 IOSurface that is initialized to the solid color. BUG=633805 Committed: https://crrev.com/318395caaf3a43683a41d09e65050649d5fedf27 Cr-Commit-Position: refs/heads/master@{#421899}

Patch Set 1 #

Patch Set 2 : More constexpr #

Total comments: 2

Patch Set 3 : Fix includes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -4 lines) Patch
M ui/accelerated_widget_mac/ca_renderer_layer_tree.h View 3 chunks +3 lines, -0 lines 0 comments Download
M ui/accelerated_widget_mac/ca_renderer_layer_tree.mm View 1 2 8 chunks +98 lines, -4 lines 0 comments Download

Messages

Total messages: 22 (15 generated)
ccameron
Note that this doesn't use a GPU bug workaround because it may need a merge ...
2 years, 8 months ago (2016-09-29 05:21:29 UTC) #4
erikchen
lgtm https://codereview.chromium.org/2378423002/diff/20001/ui/accelerated_widget_mac/ca_renderer_layer_tree.mm File ui/accelerated_widget_mac/ca_renderer_layer_tree.mm (right): https://codereview.chromium.org/2378423002/diff/20001/ui/accelerated_widget_mac/ca_renderer_layer_tree.mm#newcode169 ui/accelerated_widget_mac/ca_renderer_layer_tree.mm:169: IOSurfaceLock(io_surface, 0, NULL); s/NULL/nullptr https://codereview.chromium.org/2378423002/diff/20001/ui/accelerated_widget_mac/ca_renderer_layer_tree.mm#newcode368 ui/accelerated_widget_mac/ca_renderer_layer_tree.mm:368: if (base::mac::IsAtLeastOS10_12()) ...
2 years, 8 months ago (2016-09-29 18:23:27 UTC) #11
erikchen
On 2016/09/29 05:21:29, ccameron wrote: > Note that this doesn't use a GPU bug workaround ...
2 years, 8 months ago (2016-09-29 18:24:06 UTC) #12
ccameron
Thanks!
2 years, 8 months ago (2016-09-29 19:20:51 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2378423002/40001
2 years, 8 months ago (2016-09-29 19:21:34 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
2 years, 8 months ago (2016-09-29 19:30:16 UTC) #20
commit-bot: I haz the power
2 years, 8 months ago (2016-09-29 19:34:39 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/318395caaf3a43683a41d09e65050649d5fedf27
Cr-Commit-Position: refs/heads/master@{#421899}

Powered by Google App Engine
This is Rietveld 408576698