|
|
DescriptionMac: Fix Sierra solid color layer color-mismatch
Sierra treats the color correction of IOSurface-backed layers and solid
color layers differently. To ensure that behavior is consistent, do not
use solid color layers, rather, in such cases, use an 16x16 IOSurface
that is initialized to the solid color.
BUG=633805
Committed: https://crrev.com/318395caaf3a43683a41d09e65050649d5fedf27
Cr-Commit-Position: refs/heads/master@{#421899}
Patch Set 1 #Patch Set 2 : More constexpr #
Total comments: 2
Patch Set 3 : Fix includes #
Messages
Total messages: 22 (15 generated)
The CQ bit was checked by ccameron@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
ccameron@chromium.org changed reviewers: + erikchen@chromium.org
Note that this doesn't use a GPU bug workaround because it may need a merge into M53 (which could be hairy with that). If we stick with this long-term, I'll switch to the usual workaround format. Because it looks like they've deprecated our remote layer path in 10.12, I think we should just give up on remote layers and host everything in the browser. I have some ideas of how to do this non-intrusively.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by ccameron@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
lgtm https://codereview.chromium.org/2378423002/diff/20001/ui/accelerated_widget_m... File ui/accelerated_widget_mac/ca_renderer_layer_tree.mm (right): https://codereview.chromium.org/2378423002/diff/20001/ui/accelerated_widget_m... ui/accelerated_widget_mac/ca_renderer_layer_tree.mm:169: IOSurfaceLock(io_surface, 0, NULL); s/NULL/nullptr https://codereview.chromium.org/2378423002/diff/20001/ui/accelerated_widget_m... ui/accelerated_widget_mac/ca_renderer_layer_tree.mm:368: if (base::mac::IsAtLeastOS10_12()) { IWYU
On 2016/09/29 05:21:29, ccameron wrote: > Note that this doesn't use a GPU bug workaround because it may need a merge into > M53 (which could be hairy with that). If we stick with this long-term, I'll > switch to the usual workaround format. > > Because it looks like they've deprecated our remote layer path in 10.12, I think > we should just give up on remote layers and host everything in the browser. I > have some ideas of how to do this non-intrusively. I'm not sure I agree with this, since we'll want to move it for the MUS refactor anyways. Happy to discuss further offline.
The CQ bit was checked by ccameron@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Thanks!
The CQ bit was unchecked by ccameron@chromium.org
The CQ bit was checked by ccameron@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from erikchen@chromium.org Link to the patchset: https://codereview.chromium.org/2378423002/#ps40001 (title: "Fix includes")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Mac: Fix Sierra solid color layer color-mismatch Sierra treats the color correction of IOSurface-backed layers and solid color layers differently. To ensure that behavior is consistent, do not use solid color layers, rather, in such cases, use an 16x16 IOSurface that is initialized to the solid color. BUG=633805 ========== to ========== Mac: Fix Sierra solid color layer color-mismatch Sierra treats the color correction of IOSurface-backed layers and solid color layers differently. To ensure that behavior is consistent, do not use solid color layers, rather, in such cases, use an 16x16 IOSurface that is initialized to the solid color. BUG=633805 Committed: https://crrev.com/318395caaf3a43683a41d09e65050649d5fedf27 Cr-Commit-Position: refs/heads/master@{#421899} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/318395caaf3a43683a41d09e65050649d5fedf27 Cr-Commit-Position: refs/heads/master@{#421899} |