Further cleanups to annotation elements now that #25706 is fixed.

Further cleanups to annotation elements now that #25706 is fixed.

This CL fixes the following issues:

- In an annotation like @prefix.ClassName.foo or
  @prefix.ClassName.foo(), if "foo" couldn't be resolved, the class
  element would be returned as the annotation element.

- ConstantAstCloner wasn't properly cloning annotation elements,
  leading to weird issues in summary resynthesis tests.

- The summary resynthesizer wasn't setting AnnotationImpl.element.

R=brianwilkerson@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/7c666425a1297307026fe7361e664cead46a2051

[Paul Berry, 2016-10-03 21:46:27]

paulberry@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[Brian Wilkerson, 2016-10-03 21:53:20]

lgtm

[scheglov, 2016-10-03 21:55:26]

LGTM

[Paul Berry, 2016-10-03 22:00:39]

Description was changed from

==========
Further cleanups to annotation elements now that #25706 is fixed.

This CL fixes the following issues:

- In an annotation like @prefix.ClassName.foo or
  @prefix.ClassName.foo(), if "foo" couldn't be resolved, the class
  element would be returned as the annotation element.

- ConstantAstCloner wasn't properly cloning annotation elements,
  leading to weird issues in summary resynthesis tests.

- The summary resynthesizer wasn't setting AnnotationImpl.element.
==========

to

==========
Further cleanups to annotation elements now that #25706 is fixed.

This CL fixes the following issues:

- In an annotation like @prefix.ClassName.foo or
  @prefix.ClassName.foo(), if "foo" couldn't be resolved, the class
  element would be returned as the annotation element.

- ConstantAstCloner wasn't properly cloning annotation elements,
  leading to weird issues in summary resynthesis tests.

- The summary resynthesizer wasn't setting AnnotationImpl.element.

R=brianwilkerson@google.com, scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/7c666425a1297307026fe7361e664cead46a2051
==========

[Paul Berry, 2016-10-03 22:00:41]

Committed patchset #1 (id:1) manually as
7c666425a1297307026fe7361e664cead46a2051 (presubmit successful).