Further cleanups to annotation elements now that #25706 is fixed.

pkg/analyzer/test/src/summary/resynthesize_common.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.src.serialization.elements_test;
 
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/constant/value.dart';
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/dart/element/type.dart';
@@ skipping 524 matching lines @@
             expect(r.period, isNull, reason: desc);
             expect(r.constructorName, isNull, reason: desc);
           }
         } else {
           compareConstAsts(r.name, o.name, desc);
           expect(r.period?.lexeme, o.period?.lexeme, reason: desc);
           compareConstAsts(r.constructorName, o.constructorName, desc);
         }
         compareConstAstLists(
             r.arguments?.arguments, o.arguments?.arguments, desc);
-        Element expectedElement = o.element;
-        if (oName is PrefixedIdentifier &&
-            o.constructorName != null &&
-            o.element != null) {
-          // Due to dartbug.com/25706, [o.element] incorrectly points to the
-          // class rather than the named constructor.  Hack around this.
-          // TODO(paulberry): when dartbug.com/25706 is fixed, remove this.
-          expectedElement = (expectedElement as ClassElement)
-              .getNamedConstructor(o.constructorName.name);
-          expect(expectedElement, isNotNull, reason: desc);
-        }
-        compareElements(r.element, expectedElement, desc);
+        compareElements(r.element, o.element, desc);
         // elementAnnotation should be null; it is only used in the full AST.
         expect(o.elementAnnotation, isNull);
         expect(r.elementAnnotation, isNull);
       } else {
         fail('Not implemented for ${r.runtimeType} vs. ${o.runtimeType}');
       }
     }
   }
 
   void compareConstructorElements(ConstructorElement resynthesized,
@@ skipping 3918 matching lines @@
   }
 
   test_unresolved_annotation_prefixedNamedConstructorCall_badPrefix() {
     checkLibrary('@foo.bar.baz() class C {}');
   }
 
   test_unresolved_annotation_prefixedNamedConstructorCall_noClass() {
     checkLibrary('import "dart:async" as foo; @foo.bar.baz() class C {}');
   }
 
-  @failingTest // See dartbug.com/25706
   test_unresolved_annotation_prefixedNamedConstructorCall_noConstructor() {
     checkLibrary('import "dart:async" as foo; @foo.Future.bar() class C {}');
   }
 
   test_unresolved_annotation_prefixedUnnamedConstructorCall_badPrefix() {
     checkLibrary('@foo.bar() class C {}');
   }
 
   test_unresolved_annotation_prefixedUnnamedConstructorCall_noClass() {
     checkLibrary('import "dart:async" as foo; @foo.bar() class C {}');
@@ skipping 171 matching lines @@
       fail('Unexpectedly tried to get unlinked summary for $uri');
     }
     return serializedUnit;
   }
 
   @override
   bool hasLibrarySummary(String uri) {
     return true;
   }
 }