Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Unified Diff: pkg/analyzer/test/src/summary/resynthesize_common.dart

Issue 2391783002: Further cleanups to annotation elements now that #25706 is fixed. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/summary/resynthesize.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/src/summary/resynthesize_common.dart
diff --git a/pkg/analyzer/test/src/summary/resynthesize_common.dart b/pkg/analyzer/test/src/summary/resynthesize_common.dart
index 88b89852c55e312bbd6d302840acdf725e55438b..bc01d82aef9c73c7c69427a1373863612e08ba4b 100644
--- a/pkg/analyzer/test/src/summary/resynthesize_common.dart
+++ b/pkg/analyzer/test/src/summary/resynthesize_common.dart
@@ -542,18 +542,7 @@ abstract class AbstractResynthesizeTest extends AbstractSingleUnitTest {
}
compareConstAstLists(
r.arguments?.arguments, o.arguments?.arguments, desc);
- Element expectedElement = o.element;
- if (oName is PrefixedIdentifier &&
- o.constructorName != null &&
- o.element != null) {
- // Due to dartbug.com/25706, [o.element] incorrectly points to the
- // class rather than the named constructor. Hack around this.
- // TODO(paulberry): when dartbug.com/25706 is fixed, remove this.
- expectedElement = (expectedElement as ClassElement)
- .getNamedConstructor(o.constructorName.name);
- expect(expectedElement, isNotNull, reason: desc);
- }
- compareElements(r.element, expectedElement, desc);
+ compareElements(r.element, o.element, desc);
// elementAnnotation should be null; it is only used in the full AST.
expect(o.elementAnnotation, isNull);
expect(r.elementAnnotation, isNull);
@@ -4492,7 +4481,6 @@ typedef F();''');
checkLibrary('import "dart:async" as foo; @foo.bar.baz() class C {}');
}
- @failingTest // See dartbug.com/25706
test_unresolved_annotation_prefixedNamedConstructorCall_noConstructor() {
checkLibrary('import "dart:async" as foo; @foo.Future.bar() class C {}');
}
« no previous file with comments | « pkg/analyzer/lib/src/summary/resynthesize.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698