[Android WebView] make spellcheck off by default and opt-in using spellcheck="true" attribute.

[Android WebView] make spellcheck off by default and opt-in using spellcheck="true" attribute.

In WebView no spellchecking will be provided on html elements
unless explicitly enabled via the spellcheck="true" attribute.
The main motivation is to have consistent backward behavior in
apps that use WebView. Also this will benefit performance and
battery life on mobile devices (see crbug.com/652314).

Related blink-side patch:
https://codereview.chromium.org/2316303006/

BUG=652314, 583616, 629609
Committed: https://crrev.com/db1951995f1ce6eb4937f5e431660db383e0ece0
Cr-Commit-Position: refs/heads/master@{#423147}

[timvolodine, 2016-10-03 16:44:16]

The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 16:44:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 16:47:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 16:47:16]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[timvolodine, 2016-10-03 16:51:11]

Description was changed from

==========
[Android WebView] make spellcheck off by default and opt-in using
spellcheck="true" attribute.

In WebView no spellchecking will be provided on html elements
unless explicitly enabled via the spellcheck="true" attribute.
The main motivation is to have consistent backward behavior in
apps that use WebView. Also this will benefit performance and
battery life on mobile devices (see crbug.com/652314).

BUG=652314, 583616, 629609
==========

to

==========
[Android WebView] make spellcheck off by default and opt-in using
spellcheck="true" attribute.

In WebView no spellchecking will be provided on html elements
unless explicitly enabled via the spellcheck="true" attribute.
The main motivation is to have consistent backward behavior in
apps that use WebView. Also this will benefit performance and
battery life on mobile devices (see crbug.com/652314).

Related blink-side patch:
https://codereview.chromium.org/2316303006/

BUG=652314, 583616, 629609
==========

[timvolodine, 2016-10-03 17:23:39]

The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 17:24:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 17:26:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 17:26:20]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[timvolodine, 2016-10-03 17:33:17]

The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 17:33:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[timvolodine, 2016-10-03 18:35:07]

timvolodine@chromium.org changed reviewers:
+ tobiasjs@chromium.org, torne@chromium.org

[timvolodine, 2016-10-03 18:37:26]

timvolodine@chromium.org changed reviewers:
+ tsepez@chromium.org

[timvolodine, 2016-10-03 18:37:28]

+tsepez@ for content/public/common/common_param_traits_macros.h

[Tom Sepez, 2016-10-03 18:42:55]

LGTM on adding bool to existing struct.

[commit-bot: I haz the power, 2016-10-03 19:11:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 19:11:55]

Dry run: This issue passed the CQ dry run.

[Tobias Sargeant, 2016-10-04 14:47:09]

On 2016/10/03 18:42:55, Tom Sepez wrote:
> LGTM on adding bool to existing struct.

android_webview/ LGTM. Maybe the content/ changes should be inside OS_ANDROID,
seeing as we don't need to be able to change the default elsewhere?

[timvolodine, 2016-10-04 15:46:10]

The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 15:46:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[timvolodine, 2016-10-04 15:47:38]

On 2016/10/04 14:47:09, Tobias Sargeant wrote:
> On 2016/10/03 18:42:55, Tom Sepez wrote:
> > LGTM on adding bool to existing struct.
> 
> android_webview/ LGTM. Maybe the content/ changes should be inside OS_ANDROID,
> seeing as we don't need to be able to change the default elsewhere?

yes makes sense: moved it inside the OS_ANDROID block

[timvolodine, 2016-10-04 15:48:16]

timvolodine@chromium.org changed reviewers:
+ jam@chromium.org

[timvolodine, 2016-10-04 15:48:17]

+jam@: for content/ owner RS.

[jam, 2016-10-04 16:06:42]

lgtm

[commit-bot: I haz the power, 2016-10-04 16:31:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 16:31:11]

Dry run: This issue passed the CQ dry run.

[timvolodine, 2016-10-05 13:47:11]

The CQ bit was checked by timvolodine@chromium.org

[timvolodine, 2016-10-05 13:47:12]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
tobiasjs@chromium.org
Link to the patchset: https://codereview.chromium.org/2391613002/#ps60001
(title: "move inside the #ifdef os_android block")

[commit-bot: I haz the power, 2016-10-05 13:47:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 13:53:05]

Description was changed from

==========
[Android WebView] make spellcheck off by default and opt-in using
spellcheck="true" attribute.

In WebView no spellchecking will be provided on html elements
unless explicitly enabled via the spellcheck="true" attribute.
The main motivation is to have consistent backward behavior in
apps that use WebView. Also this will benefit performance and
battery life on mobile devices (see crbug.com/652314).

Related blink-side patch:
https://codereview.chromium.org/2316303006/

BUG=652314, 583616, 629609
==========

to

==========
[Android WebView] make spellcheck off by default and opt-in using
spellcheck="true" attribute.

In WebView no spellchecking will be provided on html elements
unless explicitly enabled via the spellcheck="true" attribute.
The main motivation is to have consistent backward behavior in
apps that use WebView. Also this will benefit performance and
battery life on mobile devices (see crbug.com/652314).

Related blink-side patch:
https://codereview.chromium.org/2316303006/

BUG=652314, 583616, 629609
==========

[commit-bot: I haz the power, 2016-10-05 13:53:06]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-05 13:57:03]

Description was changed from

==========
[Android WebView] make spellcheck off by default and opt-in using
spellcheck="true" attribute.

In WebView no spellchecking will be provided on html elements
unless explicitly enabled via the spellcheck="true" attribute.
The main motivation is to have consistent backward behavior in
apps that use WebView. Also this will benefit performance and
battery life on mobile devices (see crbug.com/652314).

Related blink-side patch:
https://codereview.chromium.org/2316303006/

BUG=652314, 583616, 629609
==========

to

==========
[Android WebView] make spellcheck off by default and opt-in using
spellcheck="true" attribute.

In WebView no spellchecking will be provided on html elements
unless explicitly enabled via the spellcheck="true" attribute.
The main motivation is to have consistent backward behavior in
apps that use WebView. Also this will benefit performance and
battery life on mobile devices (see crbug.com/652314).

Related blink-side patch:
https://codereview.chromium.org/2316303006/

BUG=652314, 583616, 629609

Committed: https://crrev.com/db1951995f1ce6eb4937f5e431660db383e0ece0
Cr-Commit-Position: refs/heads/master@{#423147}
==========

[commit-bot: I haz the power, 2016-10-05 13:57:04]

Patchset 4 (id:??) landed as
https://crrev.com/db1951995f1ce6eb4937f5e431660db383e0ece0
Cr-Commit-Position: refs/heads/master@{#423147}