Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Side by Side Diff: android_webview/native/aw_settings.cc

Issue 2391613002: [Android WebView] make spellcheck off by default and opt-in using spellcheck="true" attribute. (Closed)
Patch Set: move inside the #ifdef os_android block Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/public/common/common_param_traits_macros.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "android_webview/native/aw_settings.h" 5 #include "android_webview/native/aw_settings.h"
6 6
7 #include "android_webview/browser/aw_content_browser_client.h" 7 #include "android_webview/browser/aw_content_browser_client.h"
8 #include "android_webview/browser/renderer_host/aw_render_view_host_ext.h" 8 #include "android_webview/browser/renderer_host/aw_render_view_host_ext.h"
9 #include "android_webview/common/aw_content_client.h" 9 #include "android_webview/common/aw_content_client.h"
10 #include "android_webview/native/aw_contents.h" 10 #include "android_webview/native/aw_contents.h"
(...skipping 420 matching lines...) Expand 10 before | Expand all | Expand 10 after
431 web_prefs->record_whole_document = 431 web_prefs->record_whole_document =
432 Java_AwSettings_getRecordFullDocument(env, obj); 432 Java_AwSettings_getRecordFullDocument(env, obj);
433 433
434 // TODO(jww): This should be removed once sufficient warning has been given of 434 // TODO(jww): This should be removed once sufficient warning has been given of
435 // possible API breakage because of disabling insecure use of geolocation. 435 // possible API breakage because of disabling insecure use of geolocation.
436 web_prefs->allow_geolocation_on_insecure_origins = 436 web_prefs->allow_geolocation_on_insecure_origins =
437 Java_AwSettings_getAllowGeolocationOnInsecureOrigins(env, obj); 437 Java_AwSettings_getAllowGeolocationOnInsecureOrigins(env, obj);
438 438
439 // We use system scrollbars, so make Blink's scrollbars invisible. 439 // We use system scrollbars, so make Blink's scrollbars invisible.
440 web_prefs->hide_scrollbars = true; 440 web_prefs->hide_scrollbars = true;
441
442 // Keep spellcheck disabled on html elements unless the spellcheck="true"
443 // attribute is explicitly specified. This "opt-in" behavior is for backward
444 // consistency in apps that use WebView (see crbug.com/652314).
445 web_prefs->spellcheck_enabled_by_default = false;
441 } 446 }
442 447
443 static jlong Init(JNIEnv* env, 448 static jlong Init(JNIEnv* env,
444 const JavaParamRef<jobject>& obj, 449 const JavaParamRef<jobject>& obj,
445 const JavaParamRef<jobject>& web_contents) { 450 const JavaParamRef<jobject>& web_contents) {
446 content::WebContents* contents = content::WebContents::FromJavaWebContents( 451 content::WebContents* contents = content::WebContents::FromJavaWebContents(
447 web_contents); 452 web_contents);
448 AwSettings* settings = new AwSettings(env, obj, contents); 453 AwSettings* settings = new AwSettings(env, obj, contents);
449 return reinterpret_cast<intptr_t>(settings); 454 return reinterpret_cast<intptr_t>(settings);
450 } 455 }
451 456
452 static ScopedJavaLocalRef<jstring> GetDefaultUserAgent( 457 static ScopedJavaLocalRef<jstring> GetDefaultUserAgent(
453 JNIEnv* env, 458 JNIEnv* env,
454 const JavaParamRef<jclass>& clazz) { 459 const JavaParamRef<jclass>& clazz) {
455 return base::android::ConvertUTF8ToJavaString(env, GetUserAgent()); 460 return base::android::ConvertUTF8ToJavaString(env, GetUserAgent());
456 } 461 }
457 462
458 bool RegisterAwSettings(JNIEnv* env) { 463 bool RegisterAwSettings(JNIEnv* env) {
459 return RegisterNativesImpl(env); 464 return RegisterNativesImpl(env);
460 } 465 }
461 466
462 } // namespace android_webview 467 } // namespace android_webview
OLDNEW
« no previous file with comments | « no previous file | content/public/common/common_param_traits_macros.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698