Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2342)

Unified Diff: android_webview/native/aw_settings.cc

Issue 2391613002: [Android WebView] make spellcheck off by default and opt-in using spellcheck="true" attribute. (Closed)
Patch Set: move inside the #ifdef os_android block Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/public/common/common_param_traits_macros.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/native/aw_settings.cc
diff --git a/android_webview/native/aw_settings.cc b/android_webview/native/aw_settings.cc
index 9bc886324bcf8164212f9297d6c13bf841e6bf33..3cb71f3941025310049341824a66f55a1930f68d 100644
--- a/android_webview/native/aw_settings.cc
+++ b/android_webview/native/aw_settings.cc
@@ -438,6 +438,11 @@ void AwSettings::PopulateWebPreferencesLocked(JNIEnv* env,
// We use system scrollbars, so make Blink's scrollbars invisible.
web_prefs->hide_scrollbars = true;
+
+ // Keep spellcheck disabled on html elements unless the spellcheck="true"
+ // attribute is explicitly specified. This "opt-in" behavior is for backward
+ // consistency in apps that use WebView (see crbug.com/652314).
+ web_prefs->spellcheck_enabled_by_default = false;
}
static jlong Init(JNIEnv* env,
« no previous file with comments | « no previous file | content/public/common/common_param_traits_macros.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698