Several small changes to new UI pages

Several small changes to new UI pages

Add noopener to all target="_blank" locations.

Add link to skia source for sk_revision

Add cloud console link to bot-page and bot-list

Make task-page reload everything and only if not pending/running

BUG=652266
BUG=631047
Committed: https://github.com/luci/luci-py/commit/d40718cea5e0337cb4bc4fd242e2690accd56ab7

[kjlubick, 2016-10-03 14:51:38]

kjlubick@google.com changed reviewers:
+ jcgregorio@google.com, stephana@google.com

[kjlubick, 2016-10-03 14:51:38]

Live at
https://2371-74b4d7e-tainted-kjlubick-dot-chromium-swarm-dev.appspot.com/newu...

although there isn't anything super flashy.

On Bot-page:
https://screenshot.googleplex.com/4xriRYpgXN2

On Task-list:
https://screenshot.googleplex.com/8P819NNAkaw

On Bot-list:
https://screenshot.googleplex.com/S4qTxk5BAbm

[stephana, 2016-10-03 19:58:35]

https://codereview.chromium.org/2391583002/diff/1/appengine/swarming/elements...
File appengine/swarming/elements/res/imp/botpage/bot-page.html (right):

https://codereview.chromium.org/2391583002/diff/1/appengine/swarming/elements...
appengine/swarming/elements/res/imp/botpage/bot-page.html:453:
_cloudConsoleLink(bot) {
Should this be  

_cloudConsoleLink: function(bot) {

...?

https://codereview.chromium.org/2391583002/diff/1/appengine/swarming/elements...
appengine/swarming/elements/res/imp/botpage/bot-page.html:458: return undefined;
return false or empty string instead of undefined.

https://codereview.chromium.org/2391583002/diff/1/appengine/swarming/elements...
appengine/swarming/elements/res/imp/botpage/bot-page.html:463: link =
this._cloudConsoleLink(d.value[0], bot.bot_id);
what's the second argument ? wouldn't this make a recursive call. What's the
second argument ?

https://codereview.chromium.org/2391583002/diff/1/appengine/swarming/elements...
File appengine/swarming/elements/res/imp/tasklist/task-list.html (right):

https://codereview.chromium.org/2391583002/diff/1/appengine/swarming/elements...
appengine/swarming/elements/res/imp/tasklist/task-list.html:428: return
undefined;
who not return empty string ?

[kjlubick, 2016-10-03 20:07:45]

https://codereview.chromium.org/2391583002/diff/1/appengine/swarming/elements...
File appengine/swarming/elements/res/imp/botpage/bot-page.html (right):

https://codereview.chromium.org/2391583002/diff/1/appengine/swarming/elements...
appengine/swarming/elements/res/imp/botpage/bot-page.html:453:
_cloudConsoleLink(bot) {
On 2016/10/03 at 19:58:35, stephana wrote:
> Should this be  
> 
> _cloudConsoleLink: function(bot) {
> 
> ...?

yes.  I'm surprised it worked.

https://codereview.chromium.org/2391583002/diff/1/appengine/swarming/elements...
appengine/swarming/elements/res/imp/botpage/bot-page.html:458: return undefined;
On 2016/10/03 at 19:58:35, stephana wrote:
> return false or empty string instead of undefined.

Done.

https://codereview.chromium.org/2391583002/diff/1/appengine/swarming/elements...
appengine/swarming/elements/res/imp/botpage/bot-page.html:463: link =
this._cloudConsoleLink(d.value[0], bot.bot_id);
On 2016/10/03 at 19:58:35, stephana wrote:
> what's the second argument ? wouldn't this make a recursive call. What's the
second argument ?

This was, correctly but inexplicably, calling common-behavior._cloudConsoleLink

Naming has been updated to avoid this.

https://codereview.chromium.org/2391583002/diff/1/appengine/swarming/elements...
File appengine/swarming/elements/res/imp/tasklist/task-list.html (right):

https://codereview.chromium.org/2391583002/diff/1/appengine/swarming/elements...
appengine/swarming/elements/res/imp/tasklist/task-list.html:428: return
undefined;
On 2016/10/03 at 19:58:35, stephana wrote:
> who not return empty string ?

Empty string is a valid "href" and so the links are clickable even though they
go nowhere.  However, false seems to do what I want, so I made it return that
instead.

[stephana, 2016-10-04 13:24:32]

LGTM

https://codereview.chromium.org/2391583002/diff/1/appengine/swarming/elements...
File appengine/swarming/elements/res/imp/botpage/bot-page.html (right):

https://codereview.chromium.org/2391583002/diff/1/appengine/swarming/elements...
appengine/swarming/elements/res/imp/botpage/bot-page.html:463: link =
this._cloudConsoleLink(d.value[0], bot.bot_id);
On 2016/10/03 20:07:45, kjlubick wrote:
> On 2016/10/03 at 19:58:35, stephana wrote:
> > what's the second argument ? wouldn't this make a recursive call. What's the
> second argument ?
> 
> This was, correctly but inexplicably, calling
common-behavior._cloudConsoleLink
> 
> Naming has been updated to avoid this.

Acknowledged.

https://codereview.chromium.org/2391583002/diff/1/appengine/swarming/elements...
File appengine/swarming/elements/res/imp/tasklist/task-list.html (right):

https://codereview.chromium.org/2391583002/diff/1/appengine/swarming/elements...
appengine/swarming/elements/res/imp/tasklist/task-list.html:428: return
undefined;
On 2016/10/03 20:07:45, kjlubick wrote:
> On 2016/10/03 at 19:58:35, stephana wrote:
> > who not return empty string ?
> 
> Empty string is a valid "href" and so the links are clickable even though they
> go nowhere.  However, false seems to do what I want, so I made it return that
> instead.

Acknowledged.

[kjlubick, 2016-10-04 13:36:34]

The CQ bit was checked by kjlubick@google.com

[commit-bot: I haz the power, 2016-10-04 13:36:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 13:36:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 13:36:44]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-infra-committers".
Note that this has nothing to do with OWNERS files.

[KevinL, 2016-10-04 13:40:00]

kjlubick@chromium.org changed reviewers:
+ kjlubick@chromium.org

[KevinL, 2016-10-04 13:40:01]

lgtm

[KevinL, 2016-10-04 13:40:04]

The CQ bit was checked by kjlubick@chromium.org

[commit-bot: I haz the power, 2016-10-04 13:40:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 13:43:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 13:43:42]

Try jobs failed on following builders:
  Luci-py Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/31a8bf8630450810)

[kjlubick, 2016-10-04 13:56:22]

The CQ bit was checked by kjlubick@google.com

[kjlubick, 2016-10-04 13:56:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjlubick@chromium.org, stephana@google.com
Link to the patchset: https://codereview.chromium.org/2391583002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-10-04 13:56:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 13:59:50]

Description was changed from

==========
Several small changes to new UI pages

Add noopener to all target="_blank" locations.

Add link to skia source for sk_revision

Add cloud console link to bot-page and bot-list

Make task-page reload everything and only if not pending/running

BUG=652266
BUG=631047
==========

to

==========
Several small changes to new UI pages

Add noopener to all target="_blank" locations.

Add link to skia source for sk_revision

Add cloud console link to bot-page and bot-list

Make task-page reload everything and only if not pending/running

BUG=652266
BUG=631047

Committed:
https://github.com/luci/luci-py/commit/d40718cea5e0337cb4bc4fd242e2690accd56ab7
==========

[commit-bot: I haz the power, 2016-10-04 13:59:51]

Committed patchset #3 (id:40001) as
https://github.com/luci/luci-py/commit/d40718cea5e0337cb4bc4fd242e2690accd56ab7