Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2905)

Unified Diff: appengine/swarming/elements/res/imp/botlist/bot-list.html

Issue 2391583002: Several small changes to new UI pages (Closed) Base URL: git@github.com:luci/luci-py@uptime
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/swarming/elements/res/imp/botlist/bot-list.html
diff --git a/appengine/swarming/elements/res/imp/botlist/bot-list.html b/appengine/swarming/elements/res/imp/botlist/bot-list.html
index 0b75a220fb62af9364a628f43e7e6ceb79715b3d..00ef8a4e23f649762d864e4aaa3e59984a6fd053 100644
--- a/appengine/swarming/elements/res/imp/botlist/bot-list.html
+++ b/appengine/swarming/elements/res/imp/botlist/bot-list.html
@@ -132,6 +132,13 @@
array (we are listening to all subproperties). The element returned is
not of much use, so we'll ignore it in _hide() and use this._columns.
-->
+ <th hidden$="[[_hide('cloud_console_link', _columns.*)]]">
+ <span>Bot in Cloud Console</span>
+ <sort-toggle
+ name="cloud_console_link"
+ current="[[_sort]]">
+ </sort-toggle>
+ </th>
<th hidden$="[[_hide('task', _columns.*)]]">
<span>Current Task</span>
<sort-toggle
@@ -167,10 +174,14 @@
<a
class="center"
href$="[[_botLink(bot.bot_id)]]"
- target="_blank">
+ target="_blank"
+ rel="noopener">
[[bot.bot_id]]
</a>
</td>
+ <td hidden$="[[_hide('cloud_console_link', _columns.*)]]">
+ <a href$="[[_ccLink(bot)]]">[[_ccText(bot)]]</a>
+ </td>
<td hidden$="[[_hide('task', _columns.*)]]">
<a href$="[[_taskLink(bot.task_id)]]">[[_taskId(bot)]]</a>
</td>
@@ -542,6 +553,22 @@
return "";
},
+ _ccLink: function(bot){
+ var z = this._attribute(bot, "zone")[0];
+ if (z === "unknown") {
+ return undefined;
+ }
+ return this._cloudConsoleLink(z, bot.bot_id);
+ },
+
+ _ccText: function(bot){
+ var z = this._attribute(bot, "zone")[0];
+ if (z === "unknown") {
+ return "Not on GCE";
+ }
+ return "View Bot";
+ },
+
_androidAliasDevice: function(device) {
if (device.notReady) {
return UNAUTHENTICATED.toUpperCase();

Powered by Google App Engine
This is Rietveld 408576698