Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2365)

Unified Diff: appengine/swarming/elements/res/imp/tasklist/task-list.html

Issue 2391583002: Several small changes to new UI pages (Closed) Base URL: git@github.com:luci/luci-py@uptime
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/swarming/elements/res/imp/tasklist/task-list.html
diff --git a/appengine/swarming/elements/res/imp/tasklist/task-list.html b/appengine/swarming/elements/res/imp/tasklist/task-list.html
index 0e916f7e4f21daadb85eda94130344faebb5538c..d0be40c41e89ff8ab7f069f5a8c4c6faddfd3aa0 100644
--- a/appengine/swarming/elements/res/imp/tasklist/task-list.html
+++ b/appengine/swarming/elements/res/imp/tasklist/task-list.html
@@ -136,6 +136,14 @@
</sort-toggle>
</th>
+ <th hidden$="[[_hide('sk_revision', _columns.*)]]">
+ <span>Skia Revision</span>
+ <sort-toggle
+ name="sk_revision"
+ current="[[_sort]]">
+ </sort-toggle>
+ </th>
+
<template
is="dom-repeat"
items="[[_plainColumns]]"
@@ -193,6 +201,15 @@
</a>
</td>
+ <td hidden$="[[_hide('sk_revision', _columns.*)]]">
+ <a
+ class="center"
+ href$="[[_skLink(task)]]"
+ target="_blank">
+ [[_column('sk_revision',task)]]
+ </a>
+ </td>
+
<template
is="dom-repeat"
items="[[_plainColumns]]"
@@ -253,6 +270,10 @@
created_ts: humanTime("created_ts"),
duration: humanTime("duration"),
modified_ts: humanTime("modified_ts"),
+ sk_revision: function(task) {
+ var r = this._attribute(task, "sk_revision")[0];
+ return r.substring(0,8);
+ },
started_ts: humanTime("started_ts"),
state: function(task) {
var state = this._attribute(task, "state")[0];
@@ -401,6 +422,14 @@
this.$.page_tasks.load(url,this._auth_headers);
},
+ _skLink: function(task) {
+ var r = this._attribute(task, "sk_revision")[0];
+ if (r === "none") {
+ return false;
+ }
+ return "https://skia.googlesource.com/skia/+/" + r;
+ },
+
_tag: function(task, col) {
if (!task || !task.tagMap) {
return undefined;

Powered by Google App Engine
This is Rietveld 408576698