Remove ownership of CPDFSDK_Document from CPDFXFA_Document

Remove ownership of CPDFSDK_Document from CPDFXFA_Document

This CL updates CPDFXFA_Document so it never owns the CPDFSDK_Document. The
CPDFSDK_Document is now always owned by the CPDFXFA_Environment. This also
cleans up the strange need to reverse the order of document and form destruction
when using XFA.

Committed: https://pdfium.googlesource.com/pdfium/+/2116105b7d0545eb353264d4b42420cf51af5195

[dsinclair, 2016-10-05 15:09:03]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 15:09:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-10-05 15:17:58]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org, weili@chromium.org

[dsinclair, 2016-10-05 15:17:59]

PTAL.

https://codereview.chromium.org/2397473006/diff/1/fpdfsdk/fpdfxfa/cpdfxfa_doc...
File fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp (right):

https://codereview.chromium.org/2397473006/diff/1/fpdfsdk/fpdfxfa/cpdfxfa_doc...
fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp:261: CPDFSDK_Document* pSDKDoc =
m_pDocument->GetSDKDoc();
This is needed because PageViewEvent is fired when the CPDFXFA_Document is
destroyed but we should have already exited the FormFill Environment and wont'
have a SDK Document anymore.

[commit-bot: I haz the power, 2016-10-05 15:22:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 15:22:04]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-10-05 17:13:14]

Much better.  I think this works.

https://codereview.chromium.org/2397473006/diff/1/fpdfsdk/fpdfxfa/cpdfxfa_doc...
File fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp (right):

https://codereview.chromium.org/2397473006/diff/1/fpdfsdk/fpdfxfa/cpdfxfa_doc...
fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp:261: CPDFSDK_Document* pSDKDoc =
m_pDocument->GetSDKDoc();
On 2016/10/05 15:17:59, dsinclair wrote:
> This is needed because PageViewEvent is fired when the CPDFXFA_Document is
> destroyed but we should have already exited the FormFill Environment and wont'
> have a SDK Document anymore.

Acknowledged.

https://codereview.chromium.org/2397473006/diff/1/fpdfsdk/fpdfxfa/cpdfxfa_doc...
File fpdfsdk/fpdfxfa/cpdfxfa_document.cpp (right):

https://codereview.chromium.org/2397473006/diff/1/fpdfsdk/fpdfxfa/cpdfxfa_doc...
fpdfsdk/fpdfxfa/cpdfxfa_document.cpp:48: m_pSDKDoc = nullptr;
Do we need to null this here?

[Lei Zhang, 2016-10-05 17:14:54]

https://codereview.chromium.org/2397473006/diff/1/samples/pdfium_test.cc
File samples/pdfium_test.cc (right):

https://codereview.chromium.org/2397473006/diff/1/samples/pdfium_test.cc#newc...
samples/pdfium_test.cc:89: static void CloseDocAndForm(FPDF_DOCUMENT doc,
FPDF_FORMHANDLE form) {
If we end up here, just remove CloseDocAndForm() inline the two calls.

[dsinclair, 2016-10-05 17:55:57]

https://codereview.chromium.org/2397473006/diff/1/fpdfsdk/fpdfxfa/cpdfxfa_doc...
File fpdfsdk/fpdfxfa/cpdfxfa_document.cpp (right):

https://codereview.chromium.org/2397473006/diff/1/fpdfsdk/fpdfxfa/cpdfxfa_doc...
fpdfsdk/fpdfxfa/cpdfxfa_document.cpp:48: m_pSDKDoc = nullptr;
On 2016/10/05 17:13:14, Tom Sepez wrote:
> Do we need to null this here?

I think it's best at the moment, just to make sure that one of the cleanup code
below attempts to access the SDKDoc.

https://codereview.chromium.org/2397473006/diff/1/samples/pdfium_test.cc
File samples/pdfium_test.cc (right):

https://codereview.chromium.org/2397473006/diff/1/samples/pdfium_test.cc#newc...
samples/pdfium_test.cc:89: static void CloseDocAndForm(FPDF_DOCUMENT doc,
FPDF_FORMHANDLE form) {
On 2016/10/05 17:14:54, Lei Zhang wrote:
> If we end up here, just remove CloseDocAndForm() inline the two calls.

Done.

[dsinclair, 2016-10-05 20:11:21]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 20:11:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 20:23:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 20:23:59]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-10-05 21:53:30]

lgtm

[dsinclair, 2016-10-05 22:45:56]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-10-05 22:46:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 22:46:17]

Description was changed from

==========
Remove ownership of CPDFSDK_Document from CPDFXFA_Document

This CL updates CPDFXFA_Document so it never owns the CPDFSDK_Document. The
CPDFSDK_Document is now always owned by the CPDFXFA_Environment. This also
cleans up the strange need to reverse the order of document and form destruction
when using XFA.
==========

to

==========
Remove ownership of CPDFSDK_Document from CPDFXFA_Document

This CL updates CPDFXFA_Document so it never owns the CPDFSDK_Document. The
CPDFSDK_Document is now always owned by the CPDFXFA_Environment. This also
cleans up the strange need to reverse the order of document and form destruction
when using XFA.

Committed:
https://pdfium.googlesource.com/pdfium/+/2116105b7d0545eb353264d4b42420cf51af...
==========

[commit-bot: I haz the power, 2016-10-05 22:46:20]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/2116105b7d0545eb353264d4b42420cf51af...