Propagate error messages to UI for blimp.

Propagate error messages to UI for Blimp.

This CL added a Java side UI class to show error messages in Toast or
Snackbar.

Also modified the BlimpClientContext interface for proper error
handling.

Future work: Pulling strings from grd files, this involves some amount
of work, so setup string resources will be done in other CLs.

BUG=650832
Committed: https://crrev.com/de3b7c37ab34ad7e6d46f8d205e4e2a449c8fe9b
Cr-Commit-Position: refs/heads/master@{#424453}

[xingliu, 2016-10-05 23:42:08]

Description was changed from

==========
Propogate error messages to UI for blimp.

This CL added Java side UI class to show error messages in Toast or
Snackbar.

Also modified the BlimpClientContext interface for proper error
handling.


Future work: Pulling strings from grd files, this involves some amount
of work, so we split setup string resources into other CLs.

BUG=650832
==========

to

==========
Propogate error messages to UI for blimp.

This CL added Java side UI class to show error messages in Toast or
Snackbar.

Also modified the BlimpClientContext interface for proper error
handling.


Future work: Pulling strings from grd files, this involves some amount
of work, so setup string resources will be done in other CLs.

BUG=650832
==========

[xingliu, 2016-10-05 23:43:04]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 23:43:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 23:47:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 23:47:39]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[xingliu, 2016-10-06 00:01:33]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 00:03:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xingliu, 2016-10-06 01:17:44]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 01:18:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xingliu, 2016-10-06 01:20:06]

Description was changed from

==========
Propogate error messages to UI for blimp.

This CL added Java side UI class to show error messages in Toast or
Snackbar.

Also modified the BlimpClientContext interface for proper error
handling.


Future work: Pulling strings from grd files, this involves some amount
of work, so setup string resources will be done in other CLs.

BUG=650832
==========

to

==========
Propagate error messages to UI for Blimp.

This CL added a Java side UI class to show error messages in Toast or
Snackbar.

Also modified the BlimpClientContext interface for proper error
handling.


Future work: Pulling strings from grd files, this involves some amount
of work, so setup string resources will be done in other CLs.

BUG=650832
==========

[xingliu, 2016-10-06 01:24:01]

xingliu@chromium.org changed reviewers:
+ dtrainor@chromium.org, nyquist@chromium.org

[xingliu, 2016-10-06 01:24:02]

Please help to take a look.

This CL doesn't include string resources setup. Currently use hard coded
strings.

[xingliu, 2016-10-06 01:24:16]

Description was changed from

==========
Propagate error messages to UI for Blimp.

This CL added a Java side UI class to show error messages in Toast or
Snackbar.

Also modified the BlimpClientContext interface for proper error
handling.


Future work: Pulling strings from grd files, this involves some amount
of work, so setup string resources will be done in other CLs.

BUG=650832
==========

to

==========
Propagate error messages to UI for Blimp.

This CL added a Java side UI class to show error messages in Toast or
Snackbar.

Also modified the BlimpClientContext interface for proper error
handling.


Future work: Pulling strings from grd files, this involves some amount
of work, so setup string resources will be done in other CLs.

BUG=650832
==========

[commit-bot: I haz the power, 2016-10-06 02:40:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 02:40:50]

Dry run: This issue passed the CQ dry run.

[David Trainor- moved to gerrit, 2016-10-07 06:58:53]

thanks for splitting the big CL up.  lgtm % nits.

https://codereview.chromium.org/2391263005/diff/40001/blimp/client/core/conte...
File blimp/client/core/context/blimp_client_context_impl.cc (right):

https://codereview.chromium.org/2391263005/diff/40001/blimp/client/core/conte...
blimp/client/core/context/blimp_client_context_impl.cc:264: }
new line after }

https://codereview.chromium.org/2391263005/diff/40001/blimp/client/core/sessi...
File blimp/client/core/session/identity_source.h (right):

https://codereview.chromium.org/2391263005/diff/40001/blimp/client/core/sessi...
blimp/client/core/session/identity_source.h:14: #include
"google_apis/gaia/google_service_auth_error.h"
Do you still need this?

https://codereview.chromium.org/2391263005/diff/40001/chrome/browser/android/...
File chrome/browser/android/blimp/chrome_blimp_client_context_delegate.cc
(right):

https://codereview.chromium.org/2391263005/diff/40001/chrome/browser/android/...
chrome/browser/android/blimp/chrome_blimp_client_context_delegate.cc:42: if
(result == blimp::client::ASSIGNMENT_REQUEST_RESULT_OK) {
Remove {} for single line if.

[xingliu, 2016-10-10 17:09:51]

Fixed all nit issue, start to land this CL.

https://codereview.chromium.org/2391263005/diff/40001/blimp/client/core/conte...
File blimp/client/core/context/blimp_client_context_impl.cc (right):

https://codereview.chromium.org/2391263005/diff/40001/blimp/client/core/conte...
blimp/client/core/context/blimp_client_context_impl.cc:264: }
On 2016/10/07 06:58:53, David Trainor wrote:
> new line after }

Done.

https://codereview.chromium.org/2391263005/diff/40001/blimp/client/core/sessi...
File blimp/client/core/session/identity_source.h (right):

https://codereview.chromium.org/2391263005/diff/40001/blimp/client/core/sessi...
blimp/client/core/session/identity_source.h:14: #include
"google_apis/gaia/google_service_auth_error.h"
On 2016/10/07 06:58:53, David Trainor wrote:
> Do you still need this?

Done.

https://codereview.chromium.org/2391263005/diff/40001/chrome/browser/android/...
File chrome/browser/android/blimp/chrome_blimp_client_context_delegate.cc
(right):

https://codereview.chromium.org/2391263005/diff/40001/chrome/browser/android/...
chrome/browser/android/blimp/chrome_blimp_client_context_delegate.cc:42: if
(result == blimp::client::ASSIGNMENT_REQUEST_RESULT_OK) {
On 2016/10/07 06:58:53, David Trainor wrote:
> Remove {} for single line if.

Done.

[xingliu, 2016-10-10 17:09:58]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-10 17:10:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 18:03:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 18:03:31]

Dry run: This issue passed the CQ dry run.

[xingliu, 2016-10-10 18:24:24]

The CQ bit was checked by xingliu@chromium.org

[xingliu, 2016-10-10 18:24:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org
Link to the patchset: https://codereview.chromium.org/2391263005/#ps60001
(title: "Minor fixes.")

[commit-bot: I haz the power, 2016-10-10 18:24:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 18:36:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 18:36:15]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[xingliu, 2016-10-10 18:46:39]

xingliu@chromium.org changed reviewers:
+ mkwst@chromium.org

[xingliu, 2016-10-10 18:46:40]

mkwst@chromium.org: Please review changes in 

tools/metrics/histograms/histograms.xml

Thanks.

[xingliu, 2016-10-10 22:39:40]

Friendly ping~

[xingliu, 2016-10-10 23:26:05]

The CQ bit was checked by xingliu@chromium.org

[commit-bot: I haz the power, 2016-10-10 23:26:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 23:37:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 23:37:29]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Mike West, 2016-10-11 08:51:12]

LGTM.

[xingliu, 2016-10-11 16:25:14]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 16:25:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 16:30:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 16:30:54]

Dry run: This issue passed the CQ dry run.

[xingliu, 2016-10-11 16:31:33]

The CQ bit was checked by xingliu@chromium.org

[commit-bot: I haz the power, 2016-10-11 16:32:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 16:38:23]

Description was changed from

==========
Propagate error messages to UI for Blimp.

This CL added a Java side UI class to show error messages in Toast or
Snackbar.

Also modified the BlimpClientContext interface for proper error
handling.


Future work: Pulling strings from grd files, this involves some amount
of work, so setup string resources will be done in other CLs.

BUG=650832
==========

to

==========
Propagate error messages to UI for Blimp.

This CL added a Java side UI class to show error messages in Toast or
Snackbar.

Also modified the BlimpClientContext interface for proper error
handling.


Future work: Pulling strings from grd files, this involves some amount
of work, so setup string resources will be done in other CLs.

BUG=650832
==========

[commit-bot: I haz the power, 2016-10-11 16:38:25]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-11 16:41:31]

Description was changed from

==========
Propagate error messages to UI for Blimp.

This CL added a Java side UI class to show error messages in Toast or
Snackbar.

Also modified the BlimpClientContext interface for proper error
handling.


Future work: Pulling strings from grd files, this involves some amount
of work, so setup string resources will be done in other CLs.

BUG=650832
==========

to

==========
Propagate error messages to UI for Blimp.

This CL added a Java side UI class to show error messages in Toast or
Snackbar.

Also modified the BlimpClientContext interface for proper error
handling.

Future work: Pulling strings from grd files, this involves some amount
of work, so setup string resources will be done in other CLs.

BUG=650832

Committed: https://crrev.com/de3b7c37ab34ad7e6d46f8d205e4e2a449c8fe9b
Cr-Commit-Position: refs/heads/master@{#424453}
==========

[commit-bot: I haz the power, 2016-10-11 16:41:33]

Patchset 4 (id:??) landed as
https://crrev.com/de3b7c37ab34ad7e6d46f8d205e4e2a449c8fe9b
Cr-Commit-Position: refs/heads/master@{#424453}