Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4377)

Unified Diff: chrome/browser/android/blimp/chrome_blimp_client_context_delegate.h

Issue 2391263005: Propagate error messages to UI for blimp. (Closed)
Patch Set: Minor fixes. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/blimp/chrome_blimp_client_context_delegate.h
diff --git a/chrome/browser/android/blimp/chrome_blimp_client_context_delegate.h b/chrome/browser/android/blimp/chrome_blimp_client_context_delegate.h
index 68ba6e71d3695d1386cfb54e39a55669a7852ac8..e0249f490f1fe00418b3ecd6c048af99a5028c59 100644
--- a/chrome/browser/android/blimp/chrome_blimp_client_context_delegate.h
+++ b/chrome/browser/android/blimp/chrome_blimp_client_context_delegate.h
@@ -8,6 +8,7 @@
#include <memory>
#include "base/macros.h"
+#include "base/strings/string16.h"
#include "blimp/client/public/blimp_client_context_delegate.h"
class IdentityProvider;
@@ -38,10 +39,18 @@ class ChromeBlimpClientContextDelegate
blimp::client::AssignmentRequestResult result,
const blimp::client::Assignment& assignment) override;
std::unique_ptr<IdentityProvider> CreateIdentityProvider() override;
- void OnAuthenticationError(
- BlimpClientContextDelegate::AuthError error) override;
+ void OnAuthenticationError(const GoogleServiceAuthError& error) override;
+ void OnConnected() override;
+ void OnEngineDisconnected(int result) override;
+ void OnNetworkDisconnected(int result) override;
+
+ protected:
+ // Show an alert message in the embedder.
+ virtual void ShowMessage(const base::string16& msg, bool short_message);
private:
+ void OnDisconnected(const base::string16& reason);
+
// The profile this delegate is used for.
Profile* profile_;

Powered by Google App Engine
This is Rietveld 408576698