chrome/android/java/src/org/chromium/chrome/browser/blimp/ChromeBlimpClientContextDelegate.java - Issue 2391263005: Propagate error messages to UI for blimp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/blimp/ChromeBlimpClientContextDelegate.java

Issue 2391263005: Propagate error messages to UI for blimp. (Closed)

Patch Set: Minor fixes. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « blimp/client/test/test_blimp_client_context_delegate.h ('k') | chrome/android/java/src/org/chromium/chrome/browser/blimp/ui/BlimpMessageBuilder.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/blimp/ChromeBlimpClientContextDelegate.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/blimp/ChromeBlimpClientContextDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/blimp/ChromeBlimpClientContextDelegate.java

index 858108c7681613430c30017948613dc1d9393334..39ffa68d003c5d61b08ef7a37b88f357b829c57f 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/blimp/ChromeBlimpClientContextDelegate.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/blimp/ChromeBlimpClientContextDelegate.java

@@ -10,6 +10,8 @@ import org.chromium.base.annotations.CalledByNative;

import org.chromium.blimp_public.BlimpClientContext;

import org.chromium.blimp_public.BlimpClientContextDelegate;

import org.chromium.chrome.browser.ApplicationLifetime;

+import org.chromium.chrome.browser.blimp.ui.BlimpMessageBuilder;

+import org.chromium.chrome.browser.blimp.ui.BlimpMessageBuilder.MessageLength;

import org.chromium.chrome.browser.profiles.Profile;

import org.chromium.chrome.browser.signin.AccountSigninActivity;

import org.chromium.chrome.browser.signin.SigninAccessPoint;

@@ -62,6 +64,12 @@ public class ChromeBlimpClientContextDelegate implements BlimpClientContextDeleg

AccountSigninActivity.startAccountSigninActivity(context, SigninAccessPoint.SETTINGS);

}

+ @CalledByNative

+ private void showMessage(String message, boolean shortMessage) {

+ MessageLength length = shortMessage ? MessageLength.SHORT : MessageLength.LONG;

+ new BlimpMessageBuilder().setDuration(length).showMessage(message);

+ }

/**

* The pointer to the ChromeBlimpClientContextDelegateAndroid JNI bridge.