Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1189)

Issue 2391123003: Public Session whitelisting - updated comments for app.window.* (Closed)

Created:
4 years, 2 months ago by Ivan Šandrk
Modified:
4 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Public Session whitelisting - updated comments for app.window.* and enabled "app.window.alwaysOnTop" since it's safe. BUG=651071 Committed: https://crrev.com/454aea3b9268d20b6a8aba76fc8f49fcbb114f9b Cr-Commit-Position: refs/heads/master@{#423141}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -9 lines) Patch
M chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc View 1 chunk +7 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Ivan Šandrk
Hi Drew, I updated a couple of comments, ptal! Thanks, Ivan
4 years, 2 months ago (2016-10-05 11:59:15 UTC) #2
Andrew T Wilson (Slow)
lgtm
4 years, 2 months ago (2016-10-05 12:38:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2391123003/1
4 years, 2 months ago (2016-10-05 12:54:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 13:31:02 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 13:34:51 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/454aea3b9268d20b6a8aba76fc8f49fcbb114f9b
Cr-Commit-Position: refs/heads/master@{#423141}

Powered by Google App Engine
This is Rietveld 408576698