Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Unified Diff: chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc

Issue 2391123003: Public Session whitelisting - updated comments for app.window.* (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc
diff --git a/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc b/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc
index f930fe525edb715dfb6ab536221b7397892b01d2..cfdb92384f50ea1ef7c6abf335ac5c28d8a1e141 100644
--- a/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc
+++ b/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc
@@ -390,15 +390,13 @@ const char* const kSafePermissionStrings[] = {
// Schedule code to run at future times.
"alarms",
- // Allow, but keep PS UX on top regardless.
- // "app.window.alwaysOnTop",
-
- // TODO(isandrk): The following permissions need to be adjusted
- // (crbug/651071).
- // Fullscreen is a no-op for Public Session. Whitelisting nevertheless to
- // broaden the range of supported apps. (The recommended permission names
- // are "app.window.*" but their unprefixed counterparts are still
- // supported.)
+ // PS UX can always be seen, this one doesn't go over it so it's fine.
+ "app.window.alwaysOnTop",
+
+ // Fullscreen is crippled in Public Sessions, maximizes instead, so both
+ // fullscreen and overrideEsc are safe for use in PS. (The recommended
+ // permission names are "app.window.*" but their unprefixed counterparts are
+ // still supported.)
"app.window.fullscreen",
"app.window.fullscreen.overrideEsc",
"fullscreen",
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698