Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Side by Side Diff: chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc

Issue 2391123003: Public Session whitelisting - updated comments for app.window.* (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/extensions/device_local_account_management_pol icy_provider.h" 5 #include "chrome/browser/chromeos/extensions/device_local_account_management_pol icy_provider.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <cstddef> 9 #include <cstddef>
10 #include <string> 10 #include <string>
(...skipping 372 matching lines...) Expand 10 before | Expand all | Expand 10 after
383 383
384 // Allows access to web contents in response to user gesture. Note that this 384 // Allows access to web contents in response to user gesture. Note that this
385 // doesn't trigger a permission warning on install though, so blocking is 385 // doesn't trigger a permission warning on install though, so blocking is
386 // somewhat at odds with the spirit of the API - however I presume the API 386 // somewhat at odds with the spirit of the API - however I presume the API
387 // design assumes user-installed extensions, which we don't have here. 387 // design assumes user-installed extensions, which we don't have here.
388 // "activeTab", 388 // "activeTab",
389 389
390 // Schedule code to run at future times. 390 // Schedule code to run at future times.
391 "alarms", 391 "alarms",
392 392
393 // Allow, but keep PS UX on top regardless. 393 // PS UX can always be seen, this one doesn't go over it so it's fine.
394 // "app.window.alwaysOnTop", 394 "app.window.alwaysOnTop",
395 395
396 // TODO(isandrk): The following permissions need to be adjusted 396 // Fullscreen is crippled in Public Sessions, maximizes instead, so both
397 // (crbug/651071). 397 // fullscreen and overrideEsc are safe for use in PS. (The recommended
398 // Fullscreen is a no-op for Public Session. Whitelisting nevertheless to 398 // permission names are "app.window.*" but their unprefixed counterparts are
399 // broaden the range of supported apps. (The recommended permission names 399 // still supported.)
400 // are "app.window.*" but their unprefixed counterparts are still
401 // supported.)
402 "app.window.fullscreen", 400 "app.window.fullscreen",
403 "app.window.fullscreen.overrideEsc", 401 "app.window.fullscreen.overrideEsc",
404 "fullscreen", 402 "fullscreen",
405 "overrideEscFullscreen", 403 "overrideEscFullscreen",
406 404
407 "app.window.shape", 405 "app.window.shape",
408 406
409 // The embedded app is subject to the restrictions as well obviously. 407 // The embedded app is subject to the restrictions as well obviously.
410 "appview", 408 "appview",
411 409
(...skipping 519 matching lines...) Expand 10 before | Expand all | Expand 10 after
931 if (error) { 929 if (error) {
932 *error = l10n_util::GetStringFUTF16( 930 *error = l10n_util::GetStringFUTF16(
933 IDS_EXTENSION_CANT_INSTALL_IN_DEVICE_LOCAL_ACCOUNT, 931 IDS_EXTENSION_CANT_INSTALL_IN_DEVICE_LOCAL_ACCOUNT,
934 base::UTF8ToUTF16(extension->name()), 932 base::UTF8ToUTF16(extension->name()),
935 base::UTF8ToUTF16(extension->id())); 933 base::UTF8ToUTF16(extension->id()));
936 } 934 }
937 return false; 935 return false;
938 } 936 }
939 937
940 } // namespace chromeos 938 } // namespace chromeos
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698