Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2390823011: [turbofan] HeapConstant types should compare by handle address (Closed)

Created:
4 years, 2 months ago by mvstanton
Modified:
4 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] HeapConstant types should compare by handle address And not by pointer address. BUG= Committed: https://crrev.com/70bb93778d12cf059801cfcfef4af01522e9a04d Cr-Commit-Position: refs/heads/master@{#40106}

Patch Set 1 #

Patch Set 2 : HeapConstantType holds a HeapObject. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -23 lines) Patch
M src/compiler/simplified-lowering.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download
M src/compiler/typed-optimization.cc View 1 1 chunk +2 lines, -5 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/types.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
M src/compiler/types.cc View 1 3 chunks +5 lines, -6 lines 0 comments Download
M test/cctest/test-types.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/types-fuzz.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
mvstanton
Hi Benedikt, Here is the type change we discussed. BTW, I did find us extracting ...
4 years, 2 months ago (2016-10-07 19:33:32 UTC) #4
Benedikt Meurer
lgtm
4 years, 2 months ago (2016-10-08 16:49:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2390823011/20001
4 years, 2 months ago (2016-10-08 16:49:15 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-08 16:51:46 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-08 16:52:05 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/70bb93778d12cf059801cfcfef4af01522e9a04d
Cr-Commit-Position: refs/heads/master@{#40106}

Powered by Google App Engine
This is Rietveld 408576698