Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1471)

Unified Diff: src/compiler/types.h

Issue 2390823011: [turbofan] HeapConstant types should compare by handle address (Closed)
Patch Set: HeapConstantType holds a HeapObject. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/typer.cc ('k') | src/compiler/types.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/types.h
diff --git a/src/compiler/types.h b/src/compiler/types.h
index 9b49f6430eded06a560d711ddc7af24dc70d6870..1c758e7ce42f3dd626c66a1c7721332c835d4462 100644
--- a/src/compiler/types.h
+++ b/src/compiler/types.h
@@ -320,13 +320,13 @@ class OtherNumberConstantType : public TypeBase {
class HeapConstantType : public TypeBase {
public:
- i::Handle<i::Object> Value() { return object_; }
+ i::Handle<i::HeapObject> Value() { return object_; }
private:
friend class Type;
friend class BitsetType;
- static Type* New(i::Handle<i::Object> value, Zone* zone) {
+ static Type* New(i::Handle<i::HeapObject> value, Zone* zone) {
BitsetType::bitset bitset = BitsetType::Lub(*value);
return AsType(new (zone->New(sizeof(HeapConstantType)))
HeapConstantType(bitset, value));
@@ -337,12 +337,12 @@ class HeapConstantType : public TypeBase {
return static_cast<HeapConstantType*>(FromType(type));
}
- HeapConstantType(BitsetType::bitset bitset, i::Handle<i::Object> object);
+ HeapConstantType(BitsetType::bitset bitset, i::Handle<i::HeapObject> object);
BitsetType::bitset Lub() { return bitset_; }
BitsetType::bitset bitset_;
- Handle<i::Object> object_;
+ Handle<i::HeapObject> object_;
};
// -----------------------------------------------------------------------------
@@ -506,7 +506,7 @@ class Type {
static Type* OtherNumberConstant(double value, Zone* zone) {
return OtherNumberConstantType::New(value, zone);
}
- static Type* HeapConstant(i::Handle<i::Object> value, Zone* zone) {
+ static Type* HeapConstant(i::Handle<i::HeapObject> value, Zone* zone) {
return HeapConstantType::New(value, zone);
}
static Type* Range(double min, double max, Zone* zone) {
« no previous file with comments | « src/compiler/typer.cc ('k') | src/compiler/types.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698