Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: test/cctest/test-types.cc

Issue 2390823011: [turbofan] HeapConstant types should compare by handle address (Closed)
Patch Set: HeapConstantType holds a HeapObject. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/types.cc ('k') | test/cctest/types-fuzz.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-types.cc
diff --git a/test/cctest/test-types.cc b/test/cctest/test-types.cc
index 2e08bde0a0bf5d9dd0db261af8b70222d65b79c7..1a11e3dcfb64a821023aa40c8f74aeaa8e5fcbe6 100644
--- a/test/cctest/test-types.cc
+++ b/test/cctest/test-types.cc
@@ -195,7 +195,7 @@ struct Tests {
Handle<i::Object> value = *vt;
Type* type = T.NewConstant(value);
if (type->IsHeapConstant()) {
- CHECK(*value == *type->AsHeapConstant()->Value());
+ CHECK(value.address() == type->AsHeapConstant()->Value().address());
} else if (type->IsOtherNumberConstant()) {
CHECK(value->IsHeapNumber());
CHECK(value->Number() == type->AsOtherNumberConstant()->Value());
« no previous file with comments | « src/compiler/types.cc ('k') | test/cctest/types-fuzz.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698