Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2390733002: [inspector] Make InspectorTest.sendCommand* private (Closed)

Created:
4 years, 2 months ago by kozy
Modified:
4 years, 2 months ago
Reviewers:
alph, dgozman
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] Make InspectorTest.sendCommand* private Introduce Protocol.Domain.method(args) and Protocol.Domain.onEventName() instead. Renamed InspectorTest.evaluateInPage -> InspectorTest.addScript. Improved InspectorTest.logMessage. BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org Committed: https://crrev.com/24beac30eeb0f799c8df7dee3e8997b4420e732d Cr-Commit-Position: refs/heads/master@{#39942}

Patch Set 1 #

Patch Set 2 : id: 0 -> id: <messageId> #

Patch Set 3 : InspectorTest.eventHandler -> InspectorTest._eventHandler #

Patch Set 4 : rebased #

Total comments: 2

Patch Set 5 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+962 lines, -892 lines) Patch
M test/inspector/console/let-const-with-api.js View 3 chunks +4 lines, -4 lines 0 comments Download
M test/inspector/console/memory-setter-in-strict-mode.js View 1 chunk +2 lines, -3 lines 0 comments Download
M test/inspector/console/memory-setter-in-strict-mode-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M test/inspector/cpu-profiler/console-profile.js View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M test/inspector/cpu-profiler/console-profile-end-parameterless-crash.js View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M test/inspector/cpu-profiler/enable-disable.js View 1 2 2 chunks +16 lines, -16 lines 0 comments Download
M test/inspector/cpu-profiler/record-cpu-profile.js View 1 2 1 chunk +7 lines, -7 lines 0 comments Download
M test/inspector/cpu-profiler/stop-without-preceeding-start.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/inspector/debugger/access-obsolete-frame.js View 1 2 2 chunks +8 lines, -10 lines 0 comments Download
M test/inspector/debugger/async-console-count-doesnt-crash.js View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M test/inspector/debugger/call-frame-function-location.js View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M test/inspector/debugger/continue-to-location.js View 1 2 5 chunks +11 lines, -11 lines 0 comments Download
M test/inspector/debugger/doesnt-step-into-injected-script.js View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M test/inspector/debugger/scope-skip-variables-with-empty-name.js View 1 2 3 chunks +7 lines, -7 lines 0 comments Download
M test/inspector/debugger/scope-skip-variables-with-empty-name-expected.txt View 1 1 chunk +17 lines, -15 lines 0 comments Download
M test/inspector/debugger/script-parsed-hash.js View 1 2 2 chunks +11 lines, -12 lines 0 comments Download
M test/inspector/debugger/set-blackbox-patterns.js View 1 2 5 chunks +10 lines, -10 lines 0 comments Download
M test/inspector/debugger/set-breakpoint-before-enabling.js View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M test/inspector/debugger/set-script-source.js View 2 chunks +3 lines, -2 lines 0 comments Download
M test/inspector/debugger/step-over-caught-exception.js View 1 2 4 chunks +15 lines, -15 lines 0 comments Download
M test/inspector/debugger/stepping-with-blackboxed-ranges.js View 1 2 6 chunks +14 lines, -14 lines 0 comments Download
M test/inspector/debugger/update-call-frame-scopes.js View 1 2 2 chunks +8 lines, -9 lines 0 comments Download
M test/inspector/inspector-test.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/inspector/protocol-test.js View 1 2 3 4 chunks +101 lines, -96 lines 0 comments Download
M test/inspector/runtime/await-promise.js View 1 2 3 4 2 chunks +29 lines, -48 lines 0 comments Download
M test/inspector/runtime/await-promise-expected.txt View 1 1 chunk +77 lines, -62 lines 0 comments Download
M test/inspector/runtime/call-function-on-async.js View 9 chunks +11 lines, -24 lines 0 comments Download
M test/inspector/runtime/call-function-on-async-expected.txt View 1 2 chunks +83 lines, -67 lines 0 comments Download
M test/inspector/runtime/clear-of-command-line-api.js View 4 chunks +5 lines, -8 lines 0 comments Download
M test/inspector/runtime/clear-of-command-line-api-expected.txt View 1 1 chunk +103 lines, -53 lines 0 comments Download
M test/inspector/runtime/compile-script.js View 1 2 2 chunks +8 lines, -19 lines 0 comments Download
M test/inspector/runtime/compile-script-expected.txt View 1 1 chunk +46 lines, -31 lines 0 comments Download
M test/inspector/runtime/console-api-repeated-in-console.js View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M test/inspector/runtime/console-deprecated-methods.js View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M test/inspector/runtime/console-line-and-column.js View 1 2 1 chunk +6 lines, -23 lines 0 comments Download
M test/inspector/runtime/console-line-and-column-expected.txt View 1 chunk +41 lines, -18 lines 0 comments Download
M test/inspector/runtime/console-log-doesnt-run-microtasks.js View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M test/inspector/runtime/console-timestamp.js View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M test/inspector/runtime/evaluate-async.js View 1 2 3 4 2 chunks +13 lines, -23 lines 0 comments Download
M test/inspector/runtime/evaluate-async-expected.txt View 1 1 chunk +55 lines, -41 lines 0 comments Download
M test/inspector/runtime/evaluate-async-with-wrap-error.js View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M test/inspector/runtime/evaluate-async-with-wrap-error-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M test/inspector/runtime/evaluate-with-context-id-equal-zero.js View 1 2 3 4 1 chunk +3 lines, -8 lines 0 comments Download
M test/inspector/runtime/evaluate-with-context-id-equal-zero-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M test/inspector/runtime/get-properties.js View 1 chunk +2 lines, -1 line 0 comments Download
M test/inspector/runtime/get-properties-on-proxy.js View 2 chunks +5 lines, -5 lines 0 comments Download
M test/inspector/runtime/get-properties-on-proxy-expected.txt View 1 1 chunk +7 lines, -5 lines 0 comments Download
M test/inspector/runtime/get-properties-preview.js View 1 chunk +3 lines, -3 lines 0 comments Download
M test/inspector/runtime/property-on-console-proto.js View 2 chunks +3 lines, -4 lines 0 comments Download
M test/inspector/runtime/property-on-console-proto-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M test/inspector/runtime/run-script-async.js View 1 2 1 chunk +51 lines, -74 lines 0 comments Download
M test/inspector/runtime/run-script-async-expected.txt View 1 1 chunk +122 lines, -88 lines 0 comments Download
M test/inspector/runtime/set-or-map-entries.js View 1 2 3 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
kozy
Dmitry, please take a look.
4 years, 2 months ago (2016-10-03 16:35:28 UTC) #1
kozy
Introduced Protocol.Domain.onEvent for replacement of InspectorTest.eventHandler[Domain.Event]. Please take a look!
4 years, 2 months ago (2016-10-03 19:47:29 UTC) #2
dgozman
lgtm
4 years, 2 months ago (2016-10-03 20:21:05 UTC) #3
alph
lgtm https://codereview.chromium.org/2390733002/diff/60001/test/inspector/runtime/await-promise.js File test/inspector/runtime/await-promise.js (right): https://codereview.chromium.org/2390733002/diff/60001/test/inspector/runtime/await-promise.js#newcode45 test/inspector/runtime/await-promise.js:45: .then(_ => next()); why the change?
4 years, 2 months ago (2016-10-03 22:18:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2390733002/80001
4 years, 2 months ago (2016-10-03 23:05:52 UTC) #7
kozy
thanks! https://codereview.chromium.org/2390733002/diff/60001/test/inspector/runtime/await-promise.js File test/inspector/runtime/await-promise.js (right): https://codereview.chromium.org/2390733002/diff/60001/test/inspector/runtime/await-promise.js#newcode45 test/inspector/runtime/await-promise.js:45: .then(_ => next()); On 2016/10/03 22:18:42, alph wrote: ...
4 years, 2 months ago (2016-10-03 23:06:07 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 2 months ago (2016-10-03 23:32:59 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 23:33:17 UTC) #11
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/24beac30eeb0f799c8df7dee3e8997b4420e732d
Cr-Commit-Position: refs/heads/master@{#39942}

Powered by Google App Engine
This is Rietveld 408576698