Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Unified Diff: test/inspector/runtime/get-properties-on-proxy.js

Issue 2390733002: [inspector] Make InspectorTest.sendCommand* private (Closed)
Patch Set: addressed comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/inspector/runtime/get-properties-on-proxy.js
diff --git a/test/inspector/runtime/get-properties-on-proxy.js b/test/inspector/runtime/get-properties-on-proxy.js
index b435c5aa3ca53bf1faf65c037684137870adb1dc..40e2a961076758d61215bd08307e7b62efbcb309 100644
--- a/test/inspector/runtime/get-properties-on-proxy.js
+++ b/test/inspector/runtime/get-properties-on-proxy.js
@@ -4,7 +4,7 @@
print("Check that while Runtime.getProperties call on proxy object no user defined trap will be executed.");
-InspectorTest.evaluateInPage(`
+InspectorTest.addScript(`
var self = this;
function testFunction()
{
@@ -82,20 +82,20 @@ function testFunction()
return new Proxy({ a : 1}, handler);
}`);
-InspectorTest.sendCommandOrDie("Runtime.evaluate", { expression: "testFunction()"}, requestProperties);
+Protocol.Runtime.evaluate({ expression: "testFunction()"}).then(requestProperties);
function requestProperties(result)
{
- InspectorTest.sendCommandOrDie("Runtime.getProperties", { objectId: result.result.objectId, generatePreview: true }, checkCounter);
+ Protocol.Runtime.getProperties({ objectId: result.result.objectId, generatePreview: true }).then(checkCounter);
}
function checkCounter(result)
{
- InspectorTest.sendCommandOrDie("Runtime.evaluate", { expression: "self.counter" }, dumpCounter);
+ Protocol.Runtime.evaluate({ expression: "self.counter" }).then(dumpCounter);
}
function dumpCounter(result)
{
- InspectorTest.logObject(result);
+ InspectorTest.logMessage(result);
InspectorTest.completeTest();
}
« no previous file with comments | « test/inspector/runtime/get-properties.js ('k') | test/inspector/runtime/get-properties-on-proxy-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698